Subzero: Clean up a few areas.

Subzero: Clean up a few areas.

1. Use a reverse_range() adaptor for range-based reverse iteration through containers.

2. Remove the emitting of the commented llvm-mc command line.

3. Remove a few TODOs.

4. For commented-out declarations within a class T like this:
   // T(const T&) = delete;
   // T &operator=(const T &) = delete;
Replace them with this:
   T(const T&) = default;
   T &operator=(const T &) = default;
And try to keep them private where possible.

5. Make LivenessNode and TimerTreeNode into internal classes.

BUG= none
R=jvoung@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7e571364bcc48d361b71c1402611873fb8544117

[Jim Stichnoth, 2015-01-09 18:39:44]

stichnot@chromium.org changed reviewers:
+ jvoung@chromium.org, kschimpf@google.com

[jvoung (off chromium), 2015-01-09 19:10:43]

lgtm

https://codereview.chromium.org/830303003/diff/20001/src/IceCfgNode.cpp
File src/IceCfgNode.cpp (right):

https://codereview.chromium.org/830303003/diff/20001/src/IceCfgNode.cpp#newco...
src/IceCfgNode.cpp:251: for (auto I = Pred->getInsts().rbegin(), E =
Pred->getInsts().rend();
can this be converted to reverse_range() too?

[Jim Stichnoth, 2015-01-09 19:41:23]

https://codereview.chromium.org/830303003/diff/20001/src/IceCfgNode.cpp
File src/IceCfgNode.cpp (right):

https://codereview.chromium.org/830303003/diff/20001/src/IceCfgNode.cpp#newco...
src/IceCfgNode.cpp:251: for (auto I = Pred->getInsts().rbegin(), E =
Pred->getInsts().rend();
On 2015/01/09 19:10:43, jvoung wrote:
> can this be converted to reverse_range() too?

Done.  (I didn't do it initially because of style concerns, but now I think the
reverse_range() style wins out.)

[Jim Stichnoth, 2015-01-09 19:43:32]

Committed patchset #3 (id:40001) manually as
7e571364bcc48d361b71c1402611873fb8544117 (presubmit successful).