Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 829963002: [Android] Extract a TabModelSelectorObserver to make it more consistent. (Closed)

Created:
5 years, 11 months ago by Ted C
Modified:
5 years, 11 months ago
Reviewers:
gone
CC:
chromium-reviews, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, plundblad+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Extract a TabModelSelectorObserver to make it more consistent. BUG=344589 Committed: https://crrev.com/c4a53db2b29532074a5defe57a345f3e760ebffb Cr-Commit-Position: refs/heads/master@{#309773}

Patch Set 1 #

Patch Set 2 : Add TODO's for removal. #

Messages

Total messages: 7 (2 generated)
Ted C
PTAL
5 years, 11 months ago (2014-12-30 19:01:49 UTC) #2
gone
lgtm
5 years, 11 months ago (2014-12-30 19:16:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/829963002/20001
5 years, 11 months ago (2014-12-30 19:22:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2014-12-30 20:03:15 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2014-12-30 20:04:09 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4a53db2b29532074a5defe57a345f3e760ebffb
Cr-Commit-Position: refs/heads/master@{#309773}

Powered by Google App Engine
This is Rietveld 408576698