Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java

Issue 829963002: [Android] Extract a TabModelSelectorObserver to make it more consistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO's for removal. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserver.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java
index 053e52639f2c5f5be5b051cab2a9f598f82cd8eb..ab909b5362e1897bb712b1cbe4bb0d471392c84d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/accessibility/AccessibilityTabModelWrapper.java
@@ -13,7 +13,9 @@ import android.widget.ListView;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.Tab;
+import org.chromium.chrome.browser.tabmodel.EmptyTabModelSelectorObserver;
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
+import org.chromium.chrome.browser.tabmodel.TabModelSelectorObserver;
import org.chromium.chrome.browser.widget.accessibility.AccessibilityTabModelAdapter.AccessibilityTabModelAdapterListener;
/**
@@ -29,9 +31,8 @@ public class AccessibilityTabModelWrapper extends LinearLayout {
private ImageButton mIncognitoButton;
private TabModelSelector mTabModelSelector;
- private TabModelSelector.ChangeListener mTabModelChangeListener =
- new TabModelSelector.ChangeListener() {
-
+ private TabModelSelectorObserver mTabModelSelectorObserver =
+ new EmptyTabModelSelectorObserver() {
@Override
public void onChange() {
getAdapter().notifyDataSetChanged();
@@ -107,11 +108,11 @@ public class AccessibilityTabModelWrapper extends LinearLayout {
*/
public void setTabModelSelector(TabModelSelector modelSelector) {
if (mIsAttachedToWindow) {
- mTabModelSelector.unregisterChangeListener(mTabModelChangeListener);
+ mTabModelSelector.removeObserver(mTabModelSelectorObserver);
}
mTabModelSelector = modelSelector;
if (mIsAttachedToWindow) {
- modelSelector.registerChangeListener(mTabModelChangeListener);
+ modelSelector.addObserver(mTabModelSelectorObserver);
}
setStateBasedOnModel();
}
@@ -153,7 +154,7 @@ public class AccessibilityTabModelWrapper extends LinearLayout {
@Override
protected void onAttachedToWindow() {
- mTabModelSelector.registerChangeListener(mTabModelChangeListener);
+ mTabModelSelector.addObserver(mTabModelSelectorObserver);
mIsAttachedToWindow = true;
super.onAttachedToWindow();
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserver.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698