Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserver.java

Issue 829963002: [Android] Extract a TabModelSelectorObserver to make it more consistent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add TODO's for removal. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserver.java
index 924edb5db2028157c1b6c4446667835583cd5651..d445452cb4a0d15b9a126de7407ca86a35566c55 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserver.java
@@ -7,7 +7,6 @@ package org.chromium.chrome.browser.tabmodel;
import org.chromium.chrome.browser.EmptyTabObserver;
import org.chromium.chrome.browser.Tab;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
-import org.chromium.chrome.browser.tabmodel.TabModelSelector.ChangeListener;
import java.util.List;
@@ -19,7 +18,7 @@ public class TabModelSelectorTabObserver extends EmptyTabObserver {
private final TabModelSelector mTabModelSelector;
private final TabModelObserver mTabModelObserver;
- private ChangeListener mChangeListener;
+ private TabModelSelectorObserver mSelectorObserver;
private boolean mIsDestroyed;
/**
@@ -49,7 +48,7 @@ public class TabModelSelectorTabObserver extends EmptyTabObserver {
List<TabModel> tabModels = selector.getModels();
if (tabModels.isEmpty()) {
- mChangeListener = new ChangeListener() {
+ mSelectorObserver = new EmptyTabModelSelectorObserver() {
@Override
public void onNewTabCreated(Tab tab) {
assert false : "onChange should have happened and unregistered this listener.";
@@ -57,12 +56,12 @@ public class TabModelSelectorTabObserver extends EmptyTabObserver {
@Override
public void onChange() {
- mTabModelSelector.unregisterChangeListener(this);
- mChangeListener = null;
+ mTabModelSelector.removeObserver(this);
+ mSelectorObserver = null;
registerModelObservers();
}
};
- mTabModelSelector.registerChangeListener(mChangeListener);
+ mTabModelSelector.addObserver(mSelectorObserver);
} else {
registerModelObservers();
}
@@ -87,9 +86,9 @@ public class TabModelSelectorTabObserver extends EmptyTabObserver {
public void destroy() {
mIsDestroyed = true;
- if (mChangeListener != null) {
- mTabModelSelector.unregisterChangeListener(mChangeListener);
- mChangeListener = null;
+ if (mSelectorObserver != null) {
+ mTabModelSelector.removeObserver(mSelectorObserver);
+ mSelectorObserver = null;
}
List<TabModel> tabModels = mTabModelSelector.getModels();

Powered by Google App Engine
This is Rietveld 408576698