Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 828413005: Stop pretending MediaControls::initializeControls() will fail (Closed)

Created:
5 years, 11 months ago by fs
Modified:
5 years, 11 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Stop pretending MediaControls::initializeControls() will fail Failure here would mean programmer error, so ASSERT_NO_EXCEPTION seems enough. BUG=448795 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188464

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -57 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -2 lines 3 comments Download
M Source/core/html/shadow/MediaControls.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 1 3 chunks +18 lines, -54 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
fs
5 years, 11 months ago (2015-01-14 17:56:50 UTC) #2
philipj_slow
LGTM https://codereview.chromium.org/828413005/diff/20001/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (left): https://codereview.chromium.org/828413005/diff/20001/Source/core/html/HTMLMediaElement.cpp#oldcode3772 Source/core/html/HTMLMediaElement.cpp:3772: return false; HTMLMediaElement::createMediaControls() now always returns true, so ...
5 years, 11 months ago (2015-01-14 19:19:08 UTC) #3
fs
https://codereview.chromium.org/828413005/diff/20001/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (left): https://codereview.chromium.org/828413005/diff/20001/Source/core/html/HTMLMediaElement.cpp#oldcode3772 Source/core/html/HTMLMediaElement.cpp:3772: return false; On 2015/01/14 19:19:08, philipj wrote: > HTMLMediaElement::createMediaControls() ...
5 years, 11 months ago (2015-01-15 09:15:31 UTC) #4
philipj_slow
https://codereview.chromium.org/828413005/diff/20001/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (left): https://codereview.chromium.org/828413005/diff/20001/Source/core/html/HTMLMediaElement.cpp#oldcode3772 Source/core/html/HTMLMediaElement.cpp:3772: return false; On 2015/01/15 09:15:31, fs wrote: > On ...
5 years, 11 months ago (2015-01-15 09:43:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828413005/20001
5 years, 11 months ago (2015-01-15 10:15:49 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 11:20:47 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188464

Powered by Google App Engine
This is Rietveld 408576698