Source/core/html/HTMLMediaElement.cpp - Issue 828413005: Stop pretending MediaControls::initializeControls() will fail

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 828413005: Stop pretending MediaControls::initializeControls() will fail (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index 2abdc36a09c964a95c2230743f09eb291c2339ff..8dec65814ade48a2e35f8a1448899785b1405323 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -3768,8 +3768,6 @@ bool HTMLMediaElement::createMediaControls()

return true;

RefPtrWillBeRawPtr<MediaControls> mediaControls = MediaControls::create(*this);

- if (!mediaControls)

- return false;

philipj_slow 2015/01/14 19:19:08 HTMLMediaElement::createMediaControls() now always

fs 2015/01/15 09:15:31 I had a follow up to do that, I guess I can includ

philipj_slow 2015/01/15 09:43:01 Separately is fine.

mediaControls->reset();

if (isFullscreen())