Stop pretending MediaControls::initializeControls() will fail

Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 3750 matching lines @@
 
     return false;
 }
 
 bool HTMLMediaElement::createMediaControls()
 {
     if (hasMediaControls())
         return true;
 
     RefPtrWillBeRawPtr<MediaControls> mediaControls = MediaControls::create(*this);
-    if (!mediaControls)
-        return false;

[philipj_slow, 2015/01/14 19:19:08]

HTMLMediaElement::createMediaControls() now always returns true, so simplify one
level more?

[fs, 2015/01/15 09:15:31]

I had a follow up to do that, I guess I can include it here if you prefer.

[philipj_slow, 2015/01/15 09:43:01]

Separately is fine.

 
     mediaControls->reset();
     if (isFullscreen())
         mediaControls->enteredFullscreen();
 
     ensureUserAgentShadowRoot().appendChild(mediaControls);
 
     if (!shouldShowControls() || !inDocument())
         mediaControls->hide();
 
@@ skipping 332 matching lines @@
 
 #if ENABLE(WEB_AUDIO)
 void HTMLMediaElement::clearWeakMembers(Visitor* visitor)
 {
     if (!visitor->isAlive(m_audioSourceNode) && audioSourceProvider())
         audioSourceProvider()->setClient(nullptr);
 }
 #endif
 
 }