Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 82803005: Make sure files end with exactly one new line and police this in presubmit. (Closed)

Created:
7 years, 1 month ago by Yang
Modified:
7 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Make sure files end with exactly one new line and police this in presubmit. The changes are (excluding presubmit.py) mechanical. I added the following lines after the check and iterated the presubmit script until all errors went away: f = open(name, "w"); if contents.endswith('\n\n'):   f.write(contents[0:-1]) else:   f.write(contents + '\n') R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18017

Patch Set 1 #

Patch Set 2 : retry upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -459 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/allocation-tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arraybuffer.js View 1 chunk +0 lines, -2 lines 0 comments Download
M src/checks.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/harmony-array.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-string.js View 1 chunk +1 line, -1 line 0 comments Download
M src/heap-snapshot-generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap-snapshot-generator-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/simulator-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/simulator-x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-unbound-queue.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-unique.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/intl/collator/sr-sort.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/intl/overrides/caching.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/message/isvar.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/paren_in_arg_string.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/replacement-marker-as-argument.js View 1 chunk +1 line, -1 line 0 comments Download
M test/message/single-function-literal.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/arguments.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/arguments-load-across-eval.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/arguments-read-and-assignment.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/array-iteration.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/array-non-smi-length.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/array-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/bugs/bug-1344252.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/bugs/bug-proto.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/closures.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/compare-character.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/compare-nan.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/compiler/control-flow-1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/inline-throw.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/compiler/lazy-const-lookup.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/compiler/optimized-closures.js View 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/compiler/regress-1394.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/compiler/regress-3260426.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/compiler/regress-closures-with-eval.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/regress-inline-callfunctionstub.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/compiler/regress-toint32.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/compiler/rotate.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/const-declaration.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/cyclic-array-to-string.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/debug-breakpoints.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/debug-constructor.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-evaluate-const.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/debug-function-scopes.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/debug-ignore-breakpoints.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/debug-liveedit-3.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/debug-liveedit-check-stack.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/debug-liveedit-compile-error.js View 1 chunk +0 lines, -2 lines 0 comments Download
test/mjsunit/debug-liveedit-diff.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/debug-liveedit-utils.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/debug-mirror-cache.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/debug-setbreakpoint.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/debug-stepin-positions.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/debug-stepout-scope-part1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/elide-double-hole-check-9.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/enumeration-order.js View 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/error-accessors.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/eval-stack-trace.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/extra-arguments.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/fast-array-length.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/fast-literal.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/fun-name.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/function.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/get-prototype-of.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/getter-in-value-prototype.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/global-load-from-eval-in-with.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/global-load-from-nested-eval.js View 1 chunk +0 lines, -5 lines 0 comments Download
M test/mjsunit/harmony/array-find.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/array-findindex.js View 1 chunk +1 line, -1 line 0 comments Download
test/mjsunit/harmony/collections.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/string-repeat.js View 1 chunk +1 line, -1 line 0 comments Download
test/mjsunit/large-object-literal.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/local-load-from-eval.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/math-pow.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/math-round.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/math-sqrt.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/mirror-boolean.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mirror-undefined.js View 1 chunk +1 line, -1 line 0 comments Download
test/mjsunit/mjsunit.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/mul-exhaustive-part6.js View 1 chunk +1 line, -1 line 0 comments Download
test/mjsunit/nans.js View 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/never-optimize.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/new.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/newline-in-string.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/number-tostring.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/number-tostring-func.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/mjsunit/number-tostring-small.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/object-literal-conversions.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/object-literal-gc.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/packed-elements.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/property-object-key.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/prototype.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regexp-indexof.js View 1 chunk +1 line, -1 line 0 comments Download
test/mjsunit/regexp-results-cache.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-1017.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-1039610.js View 1 chunk +1 line, -1 line 0 comments Download
test/mjsunit/regress/regress-105.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-1066899.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-1092.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-1099.js View 1 chunk +1 line, -1 line 0 comments Download
test/mjsunit/regress/regress-1112.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-1114040.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-1117.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-1178598.js View 1 chunk +0 lines, -2 lines 0 comments Download
test/mjsunit/regress/regress-1181.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-1246.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-1254366.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-131994.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-137.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-1546.js View 1 chunk +1 line, -1 line 0 comments Download
test/mjsunit/regress/regress-1591.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-1647.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-166379.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-1748.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-1757.js View 1 chunk +1 line, -1 line 0 comments Download
test/mjsunit/regress/regress-1853.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-186.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-1919169.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-193.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-20070207.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-2027.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-2119.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-2170.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-2172.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-2250.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-2285.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-2289.js View 1 chunk +0 lines, -2 lines 0 comments Download
test/mjsunit/regress/regress-231.js View 1 chunk +1 line, -1 line 0 comments Download
test/mjsunit/regress/regress-2374.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-237617.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-2419.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-2438.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-2444.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-246.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-2570.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-2596.js View 1 chunk +0 lines, -3 lines 0 comments Download
test/mjsunit/regress/regress-2624.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-2671.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-2671-1.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-2690.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-298269.js View 1 chunk +1 line, -1 line 0 comments Download
test/mjsunit/regress/regress-2984.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-317.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-319722-ArrayBuffer.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-45469.js View 1 chunk +0 lines, -2 lines 0 comments Download
test/mjsunit/regress/regress-483.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-588599.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-619.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-670147.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-674753.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-675.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-678525.js View 1 chunk +0 lines, -2 lines 0 comments Download
test/mjsunit/regress/regress-734862.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-74.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-753.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-806473.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-85177.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-892742.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-925537.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-94873.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-990205.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-995.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-998565.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-add-minus-zero.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-array-pop-nonconfigurable.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-binop-nosse2.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-builtin-array-op.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-crbug-158185.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-178790.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-crbug-18639.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-222893.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-233737.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-245480.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-259300.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-crbug-3184.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-frame-details-null-receiver.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-map-invalidation-1.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-seqstrsetchar-ex1.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/regress/regress-seqstrsetchar-ex2.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-seqstrsetchar-ex3.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-transcendental.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/simple-constructor.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/sparse-array.js View 1 chunk +0 lines, -2 lines 0 comments Download
test/mjsunit/stack-traces-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/stack-traces-custom-lazy.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/store-dictionary.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/str-to-num.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/strict-equals.js View 1 chunk +0 lines, -4 lines 0 comments Download
test/mjsunit/string-natives.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/string-replace-gc.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/string-search.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/string-slices.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/to-precision.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/tobool.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/tools/profile.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/touint32.js View 1 chunk +0 lines, -2 lines 0 comments Download
test/mjsunit/transcendentals.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/try-finally-continue.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/unicode-string-to-number.js View 1 chunk +0 lines, -1 line 0 comments Download
test/mjsunit/unicode-test.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/with-value.js View 1 chunk +1 line, -1 line 0 comments Download
test/preparser/non-use-strict-hex-escape.js View 1 chunk +1 line, -1 line 0 comments Download
test/preparser/non-use-strict-octal-escape.js View 1 chunk +1 line, -1 line 0 comments Download
test/preparser/non-use-strict-uhex-escape.js View 1 chunk +1 line, -1 line 0 comments Download
M test/preparser/nonstrict-arguments.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/preparser/nonstrict-eval.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/preparser/nonstrict-with.js View 1 chunk +0 lines, -3 lines 0 comments Download
test/preparser/strict-const.js View 1 chunk +1 line, -1 line 0 comments Download
M test/preparser/strict-octal-indirect-regexp.js View 1 chunk +1 line, -1 line 0 comments Download
test/preparser/strict-octal-number.js View 1 chunk +1 line, -1 line 0 comments Download
test/preparser/strict-octal-regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M test/preparser/strict-octal-string.js View 1 chunk +1 line, -1 line 0 comments Download
test/preparser/strict-octal-use-strict-after.js View 1 chunk +1 line, -1 line 0 comments Download
test/preparser/strict-octal-use-strict-before.js View 1 chunk +1 line, -1 line 0 comments Download
M test/preparser/strict-with.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/arguments-bad-index.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/concat-while-having-a-bad-time.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/dfg-abs-backwards-propagation.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-add-not-number.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-arguments-alias.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-arguments-alias-escape.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-arguments-alias-one-block-overwrite.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-arguments-mixed-alias.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-arguments-out-of-bounds.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-array-dead.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-array-length-dead.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-branch-logical-not-peephole-around-osr-exit.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-branch-not-fail.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-call-function-hit-watchpoint.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-call-method-hit-watchpoint.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-and-decrement.js View 1 chunk +0 lines, -2 lines 0 comments Download
test/webkit/dfg-cfg-simplify-eliminate-set-local-type-check-then-typeof.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-cfg-simplify-phantom-get-local-on-same-block-set-local.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-compare-final-object-to-final-object-or-other-when-both-proven-final-object.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-compare-final-object-to-final-object-or-other-when-proven-final-object.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-constant-fold-first-local-read-after-block-merge.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-constant-fold-logical-not-branch.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/dfg-constant-fold-misprediction.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/dfg-cse-cfa-discrepancy.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-cse-dead-get-scoped-var.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-dead-min-one-arg.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-dead-min-two-args.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-dead-speculation.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-dead-variable-on-exit.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-double-use-of-post-simplification-double-prediction.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-double-vote-fuzz.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/dfg-ensure-non-array-array-storage-on-window.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-get-by-val-clobber.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-getter.js View 1 chunk +0 lines, -2 lines 0 comments Download
test/webkit/dfg-getter-throw.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/dfg-holy-put-by-val-interferes-with-get-array-length.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/dfg-inline-arguments-osr-exit-and-capture.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-inline-arguments-out-of-bounds.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-inline-arguments-use-directly-from-inlined-code.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-inline-arguments-use-from-all-the-places.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-inline-arguments-use-from-all-the-places-broken.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-inline-arguments-use-from-getter.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-inline-function-dot-caller.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-inline-unused-this.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-inline-unused-this-method-check.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-int-overflow-in-loop.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-int-overflow-large-constants-in-a-line.js View 1 chunk +0 lines, -2 lines 0 comments Download
test/webkit/dfg-integer-optimization.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-intrinsic-side-effect-assignment-osr-exit.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-intrinsic-unused-this.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-intrinsic-unused-this-method-check.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-max-backwards-propagation.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-min-backwards-propagation.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-mispredict-variable-but-prove-int.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-mul-big-integer-with-small-integer-and-bitor.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/webkit/dfg-mul-big-integer-with-small-integer-and-detect-overflow.js View 1 chunk +0 lines, -2 lines 0 comments Download
test/webkit/dfg-mul-big-integers.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/dfg-multi-basic-block-structure-clobber.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-multiply.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-negative-array-index.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-patchable-get-by-id-after-watchpoint.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-phantom-base.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-phantom-get-local.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-proto-access-inline-osr-exit.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-proven-sqrt-backwards-propagation.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-put-by-id-allocate-storage.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/dfg-put-by-id-allocate-storage-polymorphic.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/dfg-put-by-id-prototype-check.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-put-by-id-reallocate-storage.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/dfg-put-by-id-reallocate-storage-polymorphic.js View 1 chunk +0 lines, -2 lines 0 comments Download
test/webkit/dfg-put-by-val-setter-then-get-by-val.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/dfg-put-scoped-var-backward-flow.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-sqrt-backwards-propagation.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-store-unexpected-value-into-argument-and-osr-exit.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-string-stricteq.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-tear-off-arguments-not-activation.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-tear-off-function-dot-arguments.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-to-string-on-cell.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-to-string-on-value.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-to-string-toString-becomes-bad.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-to-string-toString-becomes-bad-with-check-structure.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-to-string-toString-in-string.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-to-string-valueOf-in-string.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-uint32-to-number.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-uint32-to-number-in-middle-of-copy-propagation.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-uint32-to-number-on-captured-variable.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-uint32-to-number-skip-then-exit.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-uint32array-overflow-constant.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/dfg-weak-js-constant-silent-fill.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/fast/js/JSON-parse-reviver.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/fast/js/deep-recursion-test.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/function-decompilation-operators.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/Array.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/Boolean.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/Date-setYear.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/Error.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/GlobalObject.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/Number.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/Object.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/Prototype.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/RegExp.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/arguments-scope.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/assignments.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/cast.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/comment-1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/comment-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/completion.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/conditional.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/constructor_length.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/crash-1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/crash-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/delete.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/empty.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/encode_decode_uri.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/eval.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/evil-n.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/exception_propagation.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/exceptions.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/func-decl.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/inbuilt_function_proto.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/iteration.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/j-comment-3.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/j-comment-4.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/literals.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/lval-exceptions.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/math.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/md5-1.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/md5-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/object_prototype.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/object_prototype_tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/operators.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/parse.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/prototype_length.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/prototype_proto.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/scope.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/statements.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/kde/var_decl_init.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/string-anchor.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/string-fontcolor.js View 1 chunk +1 line, -1 line 0 comments Download
test/webkit/fast/js/string-fontsize.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/string-link.js View 1 chunk +1 line, -1 line 0 comments Download
test/webkit/fast/js/toString-number.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/regex/assertion.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/fast/regex/constructor.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/fast/regex/dotstar.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/fast/regex/parentheses.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/function-dot-apply-replace-base.js View 1 chunk +0 lines, -3 lines 0 comments Download
M test/webkit/get-by-pname.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/get-by-pname-non-final-object.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/get-by-pname-that-looks-like-a-patchable-get-by-val.js View 1 chunk +0 lines, -2 lines 0 comments Download
test/webkit/indexed-setter-on-global-object.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/new-array-double-with-holes.js View 1 chunk +0 lines, -1 line 0 comments Download
test/webkit/regexp-in-and-foreach-handling.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/regexp-zero-length-alternatives.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/resolve-arguments-from-scope.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/sort-with-side-effecting-comparisons.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/webkit/stack-unwinding.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/string-trim.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/throw-from-finally.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/try-catch-try-try-catch-try-finally-return-catch-finally.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/try-try-return-finally-finally.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/webkit/var-declarations-zero-width.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/consarray.js View 1 chunk +0 lines, -1 line 0 comments Download
M tools/generate-trig-table.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/presubmit.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/testrunner/local/junit_output.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools/tickprocessor.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
LGTM (reviewed presubmit.py and a handful of random samples, rubberstamped the rest).
7 years, 1 month ago (2013-11-22 13:47:07 UTC) #1
Yang
7 years, 1 month ago (2013-11-22 13:53:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r18017 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698