tools/presubmit.py - Issue 82803005: Make sure files end with exactly one new line and police this in presubmit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/presubmit.py

Issue 82803005: Make sure files end with exactly one new line and police this in presubmit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: retry upload Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/presubmit.py

diff --git a/tools/presubmit.py b/tools/presubmit.py

index 9f4834c2190981b57e19df834fa2d3b4900a380b..56eac8ecea47aa9c4501a21ee7506df55911af71 100755

--- a/tools/presubmit.py

+++ b/tools/presubmit.py

@@ -362,6 +362,9 @@ class SourceProcessor(SourceFileProcessor):

else:

print "%s has trailing whitespaces in line %s." % (name, linenumbers)

result = False

+ if not contents.endswith('\n') or contents.endswith('\n\n'):

+ print "%s does not end with a single new line." % name

+ result = False

# Check two empty lines between declarations.

if name.endswith(".cc"):

line = 0

« no previous file with comments | « tools/generate-trig-table.py ('k') | tools/testrunner/local/junit_output.py » ('j') | no next file with comments »