tools/testrunner/local/junit_output.py - Issue 82803005: Make sure files end with exactly one new line and police this in presubmit.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/testrunner/local/junit_output.py

Issue 82803005: Make sure files end with exactly one new line and police this in presubmit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: retry upload Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « tools/presubmit.py ('k') | tools/tickprocessor.js » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2013 the V8 project authors. All rights reserved.	1 # Copyright 2013 the V8 project authors. All rights reserved.

2 # Redistribution and use in source and binary forms, with or without	2 # Redistribution and use in source and binary forms, with or without

3 # modification, are permitted provided that the following conditions are	3 # modification, are permitted provided that the following conditions are

4 # met:	4 # met:

5 #	5 #

6 # * Redistributions of source code must retain the above copyright	6 # * Redistributions of source code must retain the above copyright

7 # notice, this list of conditions and the following disclaimer.	7 # notice, this list of conditions and the following disclaimer.

8 # * Redistributions in binary form must reproduce the above	8 # * Redistributions in binary form must reproduce the above

9 # copyright notice, this list of conditions and the following	9 # copyright notice, this list of conditions and the following

10 # disclaimer in the documentation and/or other materials provided	10 # disclaimer in the documentation and/or other materials provided

(...skipping 28 matching lines...) Expand all Loading...
39 testCaseElement.attrib["name"] = " ".join(test_name)	39 testCaseElement.attrib["name"] = " ".join(test_name)

40 testCaseElement.attrib["time"] = str(round(test_duration, 3))	40 testCaseElement.attrib["time"] = str(round(test_duration, 3))

41 if len(test_failure):	41 if len(test_failure):

42 failureElement = xml.Element("failure")	42 failureElement = xml.Element("failure")

43 failureElement.text = test_failure	43 failureElement.text = test_failure

44 testCaseElement.append(failureElement)	44 testCaseElement.append(failureElement)

45 self.root.append(testCaseElement)	45 self.root.append(testCaseElement)

46	46

47 def FinishAndWrite(self, file):	47 def FinishAndWrite(self, file):

48 xml.ElementTree(self.root).write(file, "UTF-8")	48 xml.ElementTree(self.root).write(file, "UTF-8")

49

OLD	NEW