Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: test/mac/type_envvars/test_bundle_executable.sh

Issue 82763006: Fix gyptest-type-envvars.py for Xcode 5.0.0 (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: Remove debug Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mac/type_envvars/test_bundle_executable.sh
diff --git a/test/mac/type_envvars/test_bundle_executable.sh b/test/mac/type_envvars/test_bundle_executable.sh
index c66ce28f2e81a8e93f3ecbf6e3ef39207c5f57ef..cd993e8e6d6dbd042162454fb1598028326256bf 100755
--- a/test/mac/type_envvars/test_bundle_executable.sh
+++ b/test/mac/type_envvars/test_bundle_executable.sh
@@ -17,5 +17,4 @@ test "${WRAPPER_NAME}" = "My App.app"
[[ ! $DYLIB_INSTALL_NAME_BASE && ${DYLIB_INSTALL_NAME_BASE-_} ]]
[[ ! $LD_DYLIB_INSTALL_NAME && ${LD_DYLIB_INSTALL_NAME-_} ]]
-# Should be set, but empty.
-[[ ! $SDKROOT && ! ${SDKROOT-_} ]]
+source "$(dirname "$0")/test_check_sdkroot.sh"
Mark Mentovai 2014/03/06 17:27:29 These should all work without “source”.
sdefresne 2014/03/07 21:16:11 I'm using a git checkout, and even if I give the f
Mark Mentovai 2014/03/07 21:51:09 sdefresne wrote:

Powered by Google App Engine
This is Rietveld 408576698