test/mac/type_envvars/test_bundle_executable.sh - Issue 82763006: Fix gyptest-type-envvars.py for Xcode 5.0.0

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/mac/type_envvars/test_bundle_executable.sh

Issue 82763006: Fix gyptest-type-envvars.py for Xcode 5.0.0 (Closed) Base URL: http://gyp.googlecode.com/svn/trunk

Patch Set: Remove debug Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « pylib/gyp/xcode_emulation.py ('k') | test/mac/type_envvars/test_bundle_loadable_module.sh » ('j') | test/mac/type_envvars/test_check_sdkroot.sh » ('J')

OLD	NEW
1 #!/bin/bash	1 #!/bin/bash

2 # Copyright (c) 2012 Google Inc. All rights reserved.	2 # Copyright (c) 2012 Google Inc. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 set -e	6 set -e

7	7

8 test $MACH_O_TYPE = mh_execute	8 test $MACH_O_TYPE = mh_execute

9 test $PRODUCT_TYPE = com.apple.product-type.application	9 test $PRODUCT_TYPE = com.apple.product-type.application

10 test "${PRODUCT_NAME}" = "My App"	10 test "${PRODUCT_NAME}" = "My App"

11 test "${FULL_PRODUCT_NAME}" = "My App.app"	11 test "${FULL_PRODUCT_NAME}" = "My App.app"

12	12

13 test "${EXECUTABLE_NAME}" = "My App"	13 test "${EXECUTABLE_NAME}" = "My App"

14 test "${EXECUTABLE_PATH}" = "My App.app/Contents/MacOS/My App"	14 test "${EXECUTABLE_PATH}" = "My App.app/Contents/MacOS/My App"

15 test "${WRAPPER_NAME}" = "My App.app"	15 test "${WRAPPER_NAME}" = "My App.app"

16	16

17 [[ ! $DYLIB_INSTALL_NAME_BASE && ${DYLIB_INSTALL_NAME_BASE-_} ]]	17 [[ ! $DYLIB_INSTALL_NAME_BASE && ${DYLIB_INSTALL_NAME_BASE-_} ]]

18 [[ ! $LD_DYLIB_INSTALL_NAME && ${LD_DYLIB_INSTALL_NAME-_} ]]	18 [[ ! $LD_DYLIB_INSTALL_NAME && ${LD_DYLIB_INSTALL_NAME-_} ]]

19	19

20 # Should be set, but empty.	20 source "$(dirname "$0")/test_check_sdkroot.sh"
	Mark Mentovai 2014/03/06 17:27:29 These should all work without “source”. These should all work without “source”. sdefresne 2014/03/07 21:16:11 I'm using a git checkout, and even if I give the f Show quoted text On 2014/03/06 17:27:29, Mark Mentovai wrote: > These should all work without “source”. I'm using a git checkout, and even if I give the file +x mode, it end up not executable in the svn repository (I guess I'll have to use another CL using svn only to set the correct svn property on that file and then remove the source). The error when not using the source is: http://build.chromium.org/p/tryserver.nacl/builders/gyp-mac/builds/1581/steps... Mark Mentovai 2014/03/07 21:51:09 sdefresne wrote: sdefresne wrote: Show quoted text > I'm using a git checkout, and even if I give the file +x mode, it end up not > executable in the svn repository (I guess I'll have to use another CL using svn > only to set the correct svn property on that file and then remove the source). You still don’t want to use source, though, because it pollutes the current environment. test_check_sdkroot.sh is intended to run as a standalone, so let’s run it that way. If file modes are a problem, then use “sh test_check_sdkroot.sh”.
21 [[ ! $SDKROOT && ! ${SDKROOT-_} ]]

OLD	NEW