Fix gyptest-type-envvars.py for Xcode 5.0.0

test/mac/type_envvars/test_check_sdkroot.sh

Index: test/mac/type_envvars/test_check_sdkroot.sh
diff --git a/test/mac/type_envvars/test_check_sdkroot.sh b/test/mac/type_envvars/test_check_sdkroot.sh
new file mode 100644
index 0000000000000000000000000000000000000000..86f0edb25647e874c96e8dcafa20bd4f400ae5a1
--- /dev/null
+++ b/test/mac/type_envvars/test_check_sdkroot.sh
@@ -0,0 +1,34 @@
+#!/bin/bash
+# Copyright (c) 2014 Google Inc. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+set -e
+
+# `xcodebuild -version` output looks like
+#    Xcode 4.6.3
+#    Build version 4H1503
+# or like
+#    Xcode 3.2.6
+#    Component versions: DevToolsCore-1809.0; DevToolsSupport-1806.0
+#    BuildVersion: 10M2518
+# Convert that to '0463'
+function xcodeversion() {
+  xcodebuild -version|head -n1|sed 's,.* ,0000,;s,\.,,g;s,.*\(....\)$,\1,'

[Mark Mentovai, 2014/03/06 17:27:29]

This works for me locally too, but I have Xcode 5 also. The bots have
4.something.

The bot results from your patch set 7 (with extra debug) are at

http://build.chromium.org/p/tryserver.nacl/builders/gyp-mac/builds/1570/steps...

Here’s an excerpt

PhaseScriptExecution "Postbuild \"envtest\"" […]
[…]
** INTERNAL ERROR: Uncaught exception **
Exception: *** -[NSConcreteFileHandle writeData:]: Broken pipe
Stack:
[…]
xcodeversion=0042
SDKROOT=

EPIPE being treated as a fatal error in xcodebuild. Let’s try to fix the EPIPE.
Where’s it coming from? Well, you’re piping xcodebuild -version to head, which
is going to close its stdin early, after it’s read a single line. That could
cause EPIPE in the writer, couldn’t it?

Options:

xcodebuild -version | sed -En -e 's/^Xcode ([0-9])\.([0-9])\.([0-9])/0\1\2\3/p'

(because sed doesn’t close its input before EOF)

or

local xcodebuild_version=$(mktemp -f "$(basename "$0")")
xcodebuild -version > "${xcodebuild_version}"
head -n1 "${xcodebuild_version}" | sed 's,.* ,0000,;s,\.,,g;s,.*\(....\)$,\1,'
rm "${xcodebuild_version}"

[sdefresne, 2014/03/07 21:16:11]

OK, there were multiple incorrect assumption in my command. So, instead of using
sed, I've used awk that can do more complex conditionals. It now does work on
the bots (BTW, they have Xcode 4.2 installed, and since the sed expression
didn't support that). This is now fixed and works with the version on the bots
and locally.

+}
+
+# Returns true if |string1| is smaller than |string2|.
+# This function assumes that both strings represent Xcode version numbers
+# as returned by |xcodeversion|.
+function smaller() {
+  local min="$(echo -ne "${1}\n${2}\n"|sort -n|head -n1)"

[Mark Mentovai, 2014/03/06 17:27:29]

Can you put some spaces around your pipes for readability?

[sdefresne, 2014/03/07 21:16:11]

Done.

+  test "${min}" != "${2}"
+}
+
+# If Xcode version is older than 5.0.0, check that SDKROOT is set but empty.
+# Otherwise, check that it is set to "xcodebuild -version -sdk '' Path".
+if smaller "$(xcodeversion)" "0500"; then
+  [[ ! ${SDKROOT} && ${SDKROOT-_} ]]
+else
+  [[ "${SDKROOT}" == "$(xcodebuild -version -sdk '' Path)" ]]
+fi