Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 82763005: Reland "Implement Math.random() purely in JavaScript" plus fixes. (Closed)

Created:
7 years, 1 month ago by Sven Panne
Modified:
7 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Reland "Implement Math.random() purely in JavaScript" plus fixes. The main change is that a bit has been added to array buffers to signal that the backing store has to be freed when the buffer dies. BUG=316359 LOG=Y R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=18003

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added assertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -664 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M src/arm/lithium-arm.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +22 lines, -13 lines 0 comments Download
M src/contexts.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/globals.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/math.js View 1 chunk +8 lines, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/objects.h View 3 chunks +4 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/serialize.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/v8.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/v8.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -23 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
7 years, 1 month ago (2013-11-22 11:29:45 UTC) #1
Yang
LGTM with comment (basically what we discussed offline). https://codereview.chromium.org/82763005/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/82763005/diff/1/src/runtime.cc#newcode698 src/runtime.cc:698: free(phantom_array_buffer->backing_store()); ...
7 years, 1 month ago (2013-11-22 11:34:43 UTC) #2
Yang
On 2013/11/22 11:34:43, Yang wrote: > LGTM with comment (basically what we discussed offline). > ...
7 years, 1 month ago (2013-11-22 11:35:32 UTC) #3
Sven Panne
7 years, 1 month ago (2013-11-22 11:36:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r18003 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698