Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 827163004: Move Gpu ArithmeticMode xfer effect to _gpu files. (Closed)

Created:
5 years, 11 months ago by egdaniel
Modified:
5 years, 11 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@preCustomXP
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move Gpu ArithmeticMode xfer effect to _gpu files. BUG=skia: Committed: https://skia.googlesource.com/skia/+/16a04b84147867b62f92969ac8f4f4a9ab009aea

Patch Set 1 #

Total comments: 3

Patch Set 2 : Review cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -206 lines) Patch
M gyp/effects.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 2 chunks +7 lines, -206 lines 0 comments Download
A src/effects/SkArithmeticMode_gpu.h View 1 1 chunk +67 lines, -0 lines 0 comments Download
A src/effects/SkArithmeticMode_gpu.cpp View 1 1 chunk +174 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
egdaniel
Moving the code for arithmetic mode to its own file so when I add the ...
5 years, 11 months ago (2015-01-14 15:20:10 UTC) #2
bsalomon
lgtm, tiny nits https://codereview.chromium.org/827163004/diff/1/src/effects/SkArithmeticMode_gpu.cpp File src/effects/SkArithmeticMode_gpu.cpp (right): https://codereview.chromium.org/827163004/diff/1/src/effects/SkArithmeticMode_gpu.cpp#newcode23 src/effects/SkArithmeticMode_gpu.cpp:23: class GrGLArithmeticFP : public GrGLFragmentProcessor { ...
5 years, 11 months ago (2015-01-14 15:25:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827163004/20001
5 years, 11 months ago (2015-01-14 18:39:35 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 18:49:21 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/16a04b84147867b62f92969ac8f4f4a9ab009aea

Powered by Google App Engine
This is Rietveld 408576698