replace COMPILE_ASSERT with static_assert in net/

replace COMPILE_ASSERT with static_assert in net/

BUG=442514
TBR=abarth

Committed: https://crrev.com/91e0da983bb4efe99b22855770decd0a33a50334
Cr-Commit-Position: refs/heads/master@{#312238}

[Mostyn Bramley-Moore, 2015-01-05 21:55:20]

mostynb@opera.com changed reviewers:
+ ttuttle@chromium.org

[Mostyn Bramley-Moore, 2015-01-05 21:55:21]

@ttuttle: please take a look.

[Deprecated (see juliatuttle), 2015-01-05 22:22:39]

lgtm with nits.

https://codereview.chromium.org/826973002/diff/40001/net/base/prioritized_dis...
File net/base/prioritized_dispatcher_unittest.cc (right):

https://codereview.chromium.org/826973002/diff/40001/net/base/prioritized_dis...
net/base/prioritized_dispatcher_unittest.cc:23: IDLE < LOWEST &&
Is there a reason that this line and the next aren't on the same line?

https://codereview.chromium.org/826973002/diff/40001/net/disk_cache/blockfile...
File net/disk_cache/blockfile/disk_format.h (right):

https://codereview.chromium.org/826973002/diff/40001/net/disk_cache/blockfile...
net/disk_cache/blockfile/disk_format.h:119: static_assert(sizeof(EntryStore) ==
256, "bad EntyStore");
Fix typo ("EntyStore" -> "EntryStore") while you're here?

https://codereview.chromium.org/826973002/diff/40001/net/disk_cache/blockfile...
File net/disk_cache/blockfile/file_win.cc (right):

https://codereview.chromium.org/826973002/diff/40001/net/disk_cache/blockfile...
net/disk_cache/blockfile/file_win.cc:29: static_assert(!offsetof(MyOverlapped,
context_),
This would be clearer as "offsetof(...) == 0", if you feel like changing it.

https://codereview.chromium.org/826973002/diff/40001/net/quic/crypto/quic_cry...
File net/quic/crypto/quic_crypto_server_config.cc (right):

https://codereview.chromium.org/826973002/diff/40001/net/quic/crypto/quic_cry...
net/quic/crypto/quic_crypto_server_config.cc:1179: "overhead calculation may
underflow");
Technically I think that's overflow?

[Mostyn Bramley-Moore, 2015-01-06 00:07:08]

https://codereview.chromium.org/826973002/diff/40001/net/base/prioritized_dis...
File net/base/prioritized_dispatcher_unittest.cc (right):

https://codereview.chromium.org/826973002/diff/40001/net/base/prioritized_dis...
net/base/prioritized_dispatcher_unittest.cc:23: IDLE < LOWEST &&
On 2015/01/05 22:22:38, ttuttle wrote:
> Is there a reason that this line and the next aren't on the same line?

I was just following the original style of this code.  Joined the two lines for
you.

https://codereview.chromium.org/826973002/diff/40001/net/disk_cache/blockfile...
File net/disk_cache/blockfile/disk_format.h (right):

https://codereview.chromium.org/826973002/diff/40001/net/disk_cache/blockfile...
net/disk_cache/blockfile/disk_format.h:119: static_assert(sizeof(EntryStore) ==
256, "bad EntyStore");
On 2015/01/05 22:22:38, ttuttle wrote:
> Fix typo ("EntyStore" -> "EntryStore") while you're here?

Done.

https://codereview.chromium.org/826973002/diff/40001/net/disk_cache/blockfile...
File net/disk_cache/blockfile/file_win.cc (right):

https://codereview.chromium.org/826973002/diff/40001/net/disk_cache/blockfile...
net/disk_cache/blockfile/file_win.cc:29: static_assert(!offsetof(MyOverlapped,
context_),
On 2015/01/05 22:22:39, ttuttle wrote:
> This would be clearer as "offsetof(...) == 0", if you feel like changing it.

Done.

https://codereview.chromium.org/826973002/diff/40001/net/quic/crypto/quic_cry...
File net/quic/crypto/quic_crypto_server_config.cc (right):

https://codereview.chromium.org/826973002/diff/40001/net/quic/crypto/quic_cry...
net/quic/crypto/quic_crypto_server_config.cc:1179: "overhead calculation may
underflow");
On 2015/01/05 22:22:39, ttuttle wrote:
> Technically I think that's overflow?

Done.

[Mostyn Bramley-Moore, 2015-01-06 00:07:54]

mostynb@opera.com changed reviewers:
+ abarth@chromium.org

[Mostyn Bramley-Moore, 2015-01-06 00:07:55]

@abart: PTAL at net/base/mime_sniffer.cc

[Mostyn Bramley-Moore, 2015-01-06 00:09:47]

On 2015/01/06 00:07:55, Mostyn Bramley-Moore wrote:
> @abart: PTAL at net/base/mime_sniffer.cc

"abarth", even.

[Mostyn Bramley-Moore, 2015-01-20 09:56:36]

mostynb@opera.com changed reviewers:
+ thakis@chromium.org

[Mostyn Bramley-Moore, 2015-01-20 09:57:55]

@abarth: *ping*

I wonder if we should remove the "set noparent" for this file?

[Nico, 2015-01-20 17:28:13]

On 2015/01/20 09:57:55, Mostyn Bramley-Moore wrote:
> @abarth: *ping*
> 
> I wonder if we should remove the "set noparent" for this file?

For this CL, you can say TBR=abarth.

But yes, having a single reviewer in a noparent file who then doesn't look at a
change for 2 weeks isn't a tenable situation. Probably ask on net-dev if they
want to add more reviewers, or remove noparent, or what.

[mmenke, 2015-01-20 17:40:04]

On 2015/01/20 17:28:13, Nico wrote:
> On 2015/01/20 09:57:55, Mostyn Bramley-Moore wrote:
> > @abarth: *ping*
> > 
> > I wonder if we should remove the "set noparent" for this file?
> 
> For this CL, you can say TBR=abarth.
> 
> But yes, having a single reviewer in a noparent file who then doesn't look at
a
> change for 2 weeks isn't a tenable situation. Probably ask on net-dev if they
> want to add more reviewers, or remove noparent, or what.

+1 to TBRing it.

I don't think it makes sense to remove the "set noparent" but keep the OWNERs
file.  May well be worth removing - it was added back in
https://codereview.chromium.org/15821010 "To make it clear it must strictly
follow <a doc>".  Given that's the case for a whole bunch of components of the
network stack, and the network stack as a whole as well, seems like a link or
two to the RFC, along with plenty of unit tests, should be sufficient.

[Mostyn Bramley-Moore, 2015-01-20 17:49:30]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2015-01-20 17:49:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/826973002/60001

[commit-bot: I haz the power, 2015-01-20 19:18:02]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-20 19:19:25]

Patchset 4 (id:??) landed as
https://crrev.com/91e0da983bb4efe99b22855770decd0a33a50334
Cr-Commit-Position: refs/heads/master@{#312238}

[Mostyn Bramley-Moore, 2015-01-20 19:51:12]

It looks like net-dev requires a google profile in order to join- is there
someone I can ask to relax this requirement?

[abarth-chromium, 2015-01-21 00:57:54]

mime_sniffer.cc LGTM