net/websockets/websocket_basic_handshake_stream.cc - Issue 826973002: replace COMPILE_ASSERT with static_assert in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/websockets/websocket_basic_handshake_stream.cc

Issue 826973002: replace COMPILE_ASSERT with static_assert in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: apply fixups Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/websockets/websocket_basic_handshake_stream.cc

diff --git a/net/websockets/websocket_basic_handshake_stream.cc b/net/websockets/websocket_basic_handshake_stream.cc

index bac2438e2a4d456714b6a9cd03e9f3c899e9e708..c0f20c7266e2e05f6b78d4642a24782ecdd13242 100644

--- a/net/websockets/websocket_basic_handshake_stream.cc

+++ b/net/websockets/websocket_basic_handshake_stream.cc

@@ -272,8 +272,8 @@ bool ValidatePerMessageDeflateExtension(const WebSocketExtension& extension,

static const char kNoContextTakeover[] = "no_context_takeover";

static const char kMaxWindowBits[] = "max_window_bits";

const size_t kPrefixLen = arraysize(kClientPrefix) - 1;

- COMPILE_ASSERT(kPrefixLen == arraysize(kServerPrefix) - 1,

- the_strings_server_and_client_must_be_the_same_length);

+ static_assert(kPrefixLen == arraysize(kServerPrefix) - 1,

+ "the strings server and client must be the same length");

typedef std::vector<WebSocketExtension::Parameter> ParameterVector;

DCHECK_EQ("permessage-deflate", extension.name());