net/quic/port_suggester.cc - Issue 826973002: replace COMPILE_ASSERT with static_assert in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/port_suggester.cc

Issue 826973002: replace COMPILE_ASSERT with static_assert in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: apply fixups Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/port_suggester.cc

diff --git a/net/quic/port_suggester.cc b/net/quic/port_suggester.cc

index 6b7940e83efae21a49750ded5b579d151196d71b..b1dfa484fd54258328fc5b462cf1aadb589f4f88 100644

--- a/net/quic/port_suggester.cc

+++ b/net/quic/port_suggester.cc

@@ -16,7 +16,7 @@ PortSuggester::PortSuggester(const HostPortPair& server, uint64 seed)

base::SHA1HashBytes(

reinterpret_cast<const unsigned char*>(server.host().data()),

server.host().length(), hash_bytes);

- COMPILE_ASSERT(sizeof(seed_) < sizeof(hash_bytes), seed_larger_than_hash);

+ static_assert(sizeof(seed_) < sizeof(hash_bytes), "seed larger than hash");

memcpy(&seed_, hash_bytes, sizeof(seed_));

seed_ ^= seed ^ server.port();

}