Issue 82603002: Get rid of unused callbacks from ui::InputMethodObserver

Issue 82603002: Get rid of unused callbacks from ui::InputMethodObserver (Closed)

Created:
7 years, 1 month ago by yukawa

Modified:
7 years, 1 month ago

Reviewers:
Hiro Komatsu, bryeung, kochi, Seigo Nonaka, SteveT, kevers, Yuki

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Get rid of unused callbacks from ui::InputMethodObserver This CL removes following callbacks from ui::InputMethodObserver because no one depends on them. - ui::InputMethodObserver::OnUntranslatedIMEMessage - ui::InputMethodObserver::OnInputLocaleChanged BUG=322038 TEST=covered by unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236962

Patch Set 1 : Fix build break #

Patch Set 2 : Revise obsolete code comment #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -121 lines)			Patch
M	chrome/browser/chromeos/input_method/textinput_test_helper.h	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/textinput_test_helper.cc	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	ui/base/ime/input_method_base.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/ime/input_method_base.cc	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	ui/base/ime/input_method_base_unittest.cc	View		4 chunks	+2 lines, -36 lines	0 comments	Download
M	ui/base/ime/input_method_ibus.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/base/ime/input_method_ibus.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/base/ime/input_method_linux_x11.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/ime/input_method_observer.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	ui/base/ime/input_method_win.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/ime/mock_input_method.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	ui/base/ime/remote_input_method_win.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	ui/base/ime/remote_input_method_win_unittest.cc	View		6 chunks	+0 lines, -38 lines	0 comments	Download
M	ui/keyboard/keyboard_controller.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/views/ime/input_method_bridge.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 14 (0 generated)

Expand Messages | Collapse Messages

yukawa

+bryeung@ for the owner review of ui/keyboard/keyboard_controller.h +nona@ for the owner review of ui/views/ime/input_method_bridge.cc

7 years, 1 month ago (2013-11-22 05:41:36 UTC) #6

bryeung

swapping myself with stevet Steve: I think it's time that the OWNERS were fixed up ...

7 years, 1 month ago (2013-11-22 14:37:33 UTC) #8

SteveT

Swapping myself with Kevers who now owns this piece of functionality.

7 years, 1 month ago (2013-11-22 21:40:53 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/82603002/330001

7 years, 1 month ago (2013-11-23 04:38:28 UTC) #11

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) telemetry_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=192392

7 years, 1 month ago (2013-11-23 05:25:35 UTC) #12

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/82603002/330001

7 years, 1 month ago (2013-11-23 05:53:17 UTC) #13

Message was sent while issue was closed.

Change committed as 236962

Expand Messages | Collapse Messages