Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: ui/keyboard/keyboard_controller.h

Issue 82603002: Get rid of unused callbacks from ui::InputMethodObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revise obsolete code comment Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/base/ime/remote_input_method_win_unittest.cc ('k') | ui/views/ime/input_method_bridge.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_KEYBOARD_KEYBOARD_CONTROLLER_H_ 5 #ifndef UI_KEYBOARD_KEYBOARD_CONTROLLER_H_
6 #define UI_KEYBOARD_KEYBOARD_CONTROLLER_H_ 6 #define UI_KEYBOARD_KEYBOARD_CONTROLLER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/event_types.h" 9 #include "base/event_types.h"
10 #include "base/memory/scoped_ptr.h" 10 #include "base/memory/scoped_ptr.h"
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 67
68 // aura::WindowObserver overrides 68 // aura::WindowObserver overrides
69 virtual void OnWindowHierarchyChanged( 69 virtual void OnWindowHierarchyChanged(
70 const HierarchyChangeParams& params) OVERRIDE; 70 const HierarchyChangeParams& params) OVERRIDE;
71 71
72 // InputMethodObserver overrides 72 // InputMethodObserver overrides
73 virtual void OnTextInputTypeChanged( 73 virtual void OnTextInputTypeChanged(
74 const ui::TextInputClient* client) OVERRIDE {} 74 const ui::TextInputClient* client) OVERRIDE {}
75 virtual void OnFocus() OVERRIDE {} 75 virtual void OnFocus() OVERRIDE {}
76 virtual void OnBlur() OVERRIDE {} 76 virtual void OnBlur() OVERRIDE {}
77 virtual void OnUntranslatedIMEMessage(
78 const base::NativeEvent& event) OVERRIDE {}
79 virtual void OnCaretBoundsChanged( 77 virtual void OnCaretBoundsChanged(
80 const ui::TextInputClient* client) OVERRIDE {} 78 const ui::TextInputClient* client) OVERRIDE {}
81 virtual void OnInputLocaleChanged() OVERRIDE {}
82 virtual void OnTextInputStateChanged( 79 virtual void OnTextInputStateChanged(
83 const ui::TextInputClient* client) OVERRIDE; 80 const ui::TextInputClient* client) OVERRIDE;
84 virtual void OnInputMethodDestroyed( 81 virtual void OnInputMethodDestroyed(
85 const ui::InputMethod* input_method) OVERRIDE; 82 const ui::InputMethod* input_method) OVERRIDE;
86 83
87 // Returns true if keyboard is scheduled to hide. 84 // Returns true if keyboard is scheduled to hide.
88 bool WillHideKeyboard() const; 85 bool WillHideKeyboard() const;
89 86
90 scoped_ptr<KeyboardControllerProxy> proxy_; 87 scoped_ptr<KeyboardControllerProxy> proxy_;
91 scoped_ptr<aura::Window> container_; 88 scoped_ptr<aura::Window> container_;
92 ui::InputMethod* input_method_; 89 ui::InputMethod* input_method_;
93 bool keyboard_visible_; 90 bool keyboard_visible_;
94 91
95 ObserverList<KeyboardControllerObserver> observer_list_; 92 ObserverList<KeyboardControllerObserver> observer_list_;
96 93
97 base::WeakPtrFactory<KeyboardController> weak_factory_; 94 base::WeakPtrFactory<KeyboardController> weak_factory_;
98 95
99 DISALLOW_COPY_AND_ASSIGN(KeyboardController); 96 DISALLOW_COPY_AND_ASSIGN(KeyboardController);
100 }; 97 };
101 98
102 } // namespace keyboard 99 } // namespace keyboard
103 100
104 #endif // UI_KEYBOARD_KEYBOARD_CONTROLLER_H_ 101 #endif // UI_KEYBOARD_KEYBOARD_CONTROLLER_H_
OLDNEW
« no previous file with comments | « ui/base/ime/remote_input_method_win_unittest.cc ('k') | ui/views/ime/input_method_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698