Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: ui/base/ime/input_method_base.h

Issue 82603002: Get rid of unused callbacks from ui::InputMethodObserver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revise obsolete code comment Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_BASE_IME_INPUT_METHOD_BASE_H_ 5 #ifndef UI_BASE_IME_INPUT_METHOD_BASE_H_
6 #define UI_BASE_IME_INPUT_METHOD_BASE_H_ 6 #define UI_BASE_IME_INPUT_METHOD_BASE_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/observer_list.h" 10 #include "base/observer_list.h"
(...skipping 26 matching lines...) Expand all
37 virtual void OnFocus() OVERRIDE; 37 virtual void OnFocus() OVERRIDE;
38 virtual void OnBlur() OVERRIDE; 38 virtual void OnBlur() OVERRIDE;
39 virtual void SetFocusedTextInputClient(TextInputClient* client) OVERRIDE; 39 virtual void SetFocusedTextInputClient(TextInputClient* client) OVERRIDE;
40 virtual void DetachTextInputClient(TextInputClient* client) OVERRIDE; 40 virtual void DetachTextInputClient(TextInputClient* client) OVERRIDE;
41 virtual TextInputClient* GetTextInputClient() const OVERRIDE; 41 virtual TextInputClient* GetTextInputClient() const OVERRIDE;
42 42
43 // If a derived class overrides this method, it should call parent's 43 // If a derived class overrides this method, it should call parent's
44 // implementation. 44 // implementation.
45 virtual void OnTextInputTypeChanged(const TextInputClient* client) OVERRIDE; 45 virtual void OnTextInputTypeChanged(const TextInputClient* client) OVERRIDE;
46 virtual void OnCaretBoundsChanged(const TextInputClient* client) OVERRIDE; 46 virtual void OnCaretBoundsChanged(const TextInputClient* client) OVERRIDE;
47 virtual void OnInputLocaleChanged() OVERRIDE;
48 47
49 virtual TextInputType GetTextInputType() const OVERRIDE; 48 virtual TextInputType GetTextInputType() const OVERRIDE;
50 virtual TextInputMode GetTextInputMode() const OVERRIDE; 49 virtual TextInputMode GetTextInputMode() const OVERRIDE;
51 virtual bool CanComposeInline() const OVERRIDE; 50 virtual bool CanComposeInline() const OVERRIDE;
52 51
53 virtual void AddObserver(InputMethodObserver* observer) OVERRIDE; 52 virtual void AddObserver(InputMethodObserver* observer) OVERRIDE;
54 virtual void RemoveObserver(InputMethodObserver* observer) OVERRIDE; 53 virtual void RemoveObserver(InputMethodObserver* observer) OVERRIDE;
55 54
56 protected: 55 protected:
57 virtual void OnWillChangeFocusedClient(TextInputClient* focused_before, 56 virtual void OnWillChangeFocusedClient(TextInputClient* focused_before,
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 ObserverList<InputMethodObserver> observer_list_; 98 ObserverList<InputMethodObserver> observer_list_;
100 99
101 bool system_toplevel_window_focused_; 100 bool system_toplevel_window_focused_;
102 101
103 DISALLOW_COPY_AND_ASSIGN(InputMethodBase); 102 DISALLOW_COPY_AND_ASSIGN(InputMethodBase);
104 }; 103 };
105 104
106 } // namespace ui 105 } // namespace ui
107 106
108 #endif // UI_BASE_IME_INPUT_METHOD_BASE_H_ 107 #endif // UI_BASE_IME_INPUT_METHOD_BASE_H_
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/input_method/textinput_test_helper.cc ('k') | ui/base/ime/input_method_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698