Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 825353003: Revert of Remove deprecated methods from Pickle. (Closed)

Created:
5 years, 12 months ago by Avi (use Gerrit)
Modified:
5 years, 12 months ago
Reviewers:
nasko
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org, tfarina, tzik, jam, piman+watch_chromium.org, feature-media-reviews_chromium.org, dcheng, noyau+watch_chromium.org, nhiroki, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org, erikwright+watch_chromium.org, jdduke+watch_chromium.org, kinuko+fileapi, jbates
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove deprecated methods from Pickle. (patchset #10 id:180001 of https://codereview.chromium.org/818833004/) Reason for revert: Allegedly causes a performance hit: http://crbug.com/445173 Original issue's description: > Remove deprecated methods from Pickle. > > BUG=444578 > TEST=none > R=nasko@chromium.org > TBR=ben@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/b740bfe23ae7ad244356a4a7538b95ae560251db TBR=nasko@chromium.org NOTREECHECKS=true NOTRY=true BUG=444578 Committed: https://crrev.com/f13c491db505994d71f7c2c4e11b93f726e9933a Cr-Commit-Position: refs/heads/master@{#309689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+487 lines, -373 lines) Patch
M base/pickle.h View 4 chunks +84 lines, -15 lines 0 comments Download
M base/pickle_unittest.cc View 14 chunks +32 lines, -32 lines 0 comments Download
M chrome/browser/extensions/api/automation_internal/automation_internal_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/page_capture/page_capture_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_drag_data.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/bookmarks/browser/bookmark_node_data.h View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_node_data.cc View 4 chunks +13 lines, -12 lines 0 comments Download
M components/sessions/base_session_service_commands.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M components/sessions/session_service_commands.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.h View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.cc View 9 chunks +35 lines, -25 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/zygote_host/zygote_host_impl_linux.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M content/child/resource_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/threaded_data_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/cc_messages.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/child_process_sandbox_support_impl_linux.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M content/common/common_param_traits_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/content_param_traits.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/font_config_ipc_linux.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M content/common/gamepad_param_traits.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/media/media_param_traits.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M content/common/page_state_serialization.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/common/resource_messages.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/ssl_status_serialization.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M content/public/common/common_param_traits.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/common_param_traits.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/zygote/zygote_linux.h View 4 chunks +7 lines, -3 lines 0 comments Download
M content/zygote/zygote_linux.cc View 9 chunks +23 lines, -17 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/script_executor.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/user_script.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M extensions/renderer/user_script_set.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/ipc/gpu_command_buffer_traits.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_channel_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M ipc/ipc_message.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_message_utils.h View 15 chunks +15 lines, -15 lines 0 comments Download
M ipc/ipc_message_utils.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M ipc/ipc_sync_message.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/param_traits_read_macros.h View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/x509_certificate.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/cert/x509_certificate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/cert/x509_certificate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_headers.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_headers.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_info.cc View 4 chunks +15 lines, -15 lines 0 comments Download
M net/http/http_vary_data.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_vary_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/crypto/quic_server_info.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ppapi/nacl_irt/ppapi_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/raw_var_data.cc View 9 chunks +19 lines, -19 lines 0 comments Download
M ppapi/proxy/serialized_flash_menu.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ppapi/proxy/serialized_var.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromoting_param_traits.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M sandbox/linux/syscall_broker/broker_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/syscall_broker/broker_host.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M skia/ext/skia_utils_base.h View 1 chunk +5 lines, -5 lines 0 comments Download
M skia/ext/skia_utils_base.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M storage/browser/fileapi/file_system_usage_cache.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/sandbox_directory_database.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/sandbox_prioritized_origin_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/clipboard/clipboard_test_template.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/base/clipboard/custom_data_helper.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/ipc/gfx_param_traits.cc View 9 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Created Revert of Remove deprecated methods from Pickle.
5 years, 12 months ago (2014-12-28 19:04:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/825353003/1
5 years, 12 months ago (2014-12-28 19:05:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-28 19:06:55 UTC) #3
commit-bot: I haz the power
5 years, 12 months ago (2014-12-28 19:07:52 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f13c491db505994d71f7c2c4e11b93f726e9933a
Cr-Commit-Position: refs/heads/master@{#309689}

Powered by Google App Engine
This is Rietveld 408576698