Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: components/bookmarks/browser/bookmark_node_data.cc

Issue 825353003: Revert of Remove deprecated methods from Pickle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_node_data.cc
diff --git a/components/bookmarks/browser/bookmark_node_data.cc b/components/bookmarks/browser/bookmark_node_data.cc
index 5f134eee3bb802c89ed9d62b0edfc9ba91636d33..2d6e064053561e4f51a0b1ce9182f3948c9d5f01 100644
--- a/components/bookmarks/browser/bookmark_node_data.cc
+++ b/components/bookmarks/browser/bookmark_node_data.cc
@@ -57,12 +57,13 @@
}
}
-bool BookmarkNodeData::Element::ReadFromPickle(PickleIterator* iterator) {
+bool BookmarkNodeData::Element::ReadFromPickle(Pickle* pickle,
+ PickleIterator* iterator) {
std::string url_spec;
- if (!iterator->ReadBool(&is_url) ||
- !iterator->ReadString(&url_spec) ||
- !iterator->ReadString16(&title) ||
- !iterator->ReadInt64(&id_)) {
+ if (!pickle->ReadBool(iterator, &is_url) ||
+ !pickle->ReadString(iterator, &url_spec) ||
+ !pickle->ReadString16(iterator, &title) ||
+ !pickle->ReadInt64(iterator, &id_)) {
return false;
}
url = GURL(url_spec);
@@ -70,13 +71,13 @@
date_folder_modified = base::Time();
meta_info_map.clear();
size_t meta_field_count;
- if (!iterator->ReadSizeT(&meta_field_count))
+ if (!pickle->ReadSizeT(iterator, &meta_field_count))
return false;
for (size_t i = 0; i < meta_field_count; ++i) {
std::string key;
std::string value;
- if (!iterator->ReadString(&key) ||
- !iterator->ReadString(&value)) {
+ if (!pickle->ReadString(iterator, &key) ||
+ !pickle->ReadString(iterator, &value)) {
return false;
}
meta_info_map[key] = value;
@@ -84,12 +85,12 @@
children.clear();
if (!is_url) {
size_t children_count;
- if (!iterator->ReadSizeT(&children_count))
+ if (!pickle->ReadSizeT(iterator, &children_count))
return false;
children.reserve(children_count);
for (size_t i = 0; i < children_count; ++i) {
children.push_back(Element());
- if (!children.back().ReadFromPickle(iterator))
+ if (!children.back().ReadFromPickle(pickle, iterator))
return false;
}
}
@@ -244,11 +245,11 @@
PickleIterator data_iterator(*pickle);
size_t element_count;
if (profile_path_.ReadFromPickle(&data_iterator) &&
- data_iterator.ReadSizeT(&element_count)) {
+ pickle->ReadSizeT(&data_iterator, &element_count)) {
std::vector<Element> tmp_elements;
tmp_elements.resize(element_count);
for (size_t i = 0; i < element_count; ++i) {
- if (!tmp_elements[i].ReadFromPickle(&data_iterator)) {
+ if (!tmp_elements[i].ReadFromPickle(pickle, &data_iterator)) {
return false;
}
}
« no previous file with comments | « components/bookmarks/browser/bookmark_node_data.h ('k') | components/sessions/base_session_service_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698