OLD | NEW |
1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "sandbox/linux/syscall_broker/broker_host.h" | 5 #include "sandbox/linux/syscall_broker/broker_host.h" |
6 | 6 |
7 #include <fcntl.h> | 7 #include <fcntl.h> |
8 #include <sys/socket.h> | 8 #include <sys/socket.h> |
9 #include <sys/stat.h> | 9 #include <sys/stat.h> |
10 #include <sys/syscall.h> | 10 #include <sys/syscall.h> |
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
103 int access_errno = errno; | 103 int access_errno = errno; |
104 if (!access_ret) | 104 if (!access_ret) |
105 write_pickle->WriteInt(0); | 105 write_pickle->WriteInt(0); |
106 else | 106 else |
107 write_pickle->WriteInt(-access_errno); | 107 write_pickle->WriteInt(-access_errno); |
108 } else { | 108 } else { |
109 write_pickle->WriteInt(-policy.denied_errno()); | 109 write_pickle->WriteInt(-policy.denied_errno()); |
110 } | 110 } |
111 } | 111 } |
112 | 112 |
113 // Handle a |command_type| request contained in |iter| and send the reply | 113 // Handle a |command_type| request contained in |read_pickle| and send the reply |
114 // on |reply_ipc|. | 114 // on |reply_ipc|. |
115 // Currently COMMAND_OPEN and COMMAND_ACCESS are supported. | 115 // Currently COMMAND_OPEN and COMMAND_ACCESS are supported. |
116 bool HandleRemoteCommand(const BrokerPolicy& policy, | 116 bool HandleRemoteCommand(const BrokerPolicy& policy, |
117 IPCCommand command_type, | 117 IPCCommand command_type, |
118 int reply_ipc, | 118 int reply_ipc, |
| 119 const Pickle& read_pickle, |
119 PickleIterator iter) { | 120 PickleIterator iter) { |
120 // Currently all commands have two arguments: filename and flags. | 121 // Currently all commands have two arguments: filename and flags. |
121 std::string requested_filename; | 122 std::string requested_filename; |
122 int flags = 0; | 123 int flags = 0; |
123 if (!iter.ReadString(&requested_filename) || !iter.ReadInt(&flags)) | 124 if (!read_pickle.ReadString(&iter, &requested_filename) || |
| 125 !read_pickle.ReadInt(&iter, &flags)) { |
124 return false; | 126 return false; |
| 127 } |
125 | 128 |
126 Pickle write_pickle; | 129 Pickle write_pickle; |
127 std::vector<int> opened_files; | 130 std::vector<int> opened_files; |
128 | 131 |
129 switch (command_type) { | 132 switch (command_type) { |
130 case COMMAND_ACCESS: | 133 case COMMAND_ACCESS: |
131 AccessFileForIPC(policy, requested_filename, flags, &write_pickle); | 134 AccessFileForIPC(policy, requested_filename, flags, &write_pickle); |
132 break; | 135 break; |
133 case COMMAND_OPEN: | 136 case COMMAND_OPEN: |
134 OpenFileForIPC( | 137 OpenFileForIPC( |
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
190 if (msg_len < 0 || fds.size() != 1 || fds[0]->get() < 0) { | 193 if (msg_len < 0 || fds.size() != 1 || fds[0]->get() < 0) { |
191 PLOG(ERROR) << "Error reading message from the client"; | 194 PLOG(ERROR) << "Error reading message from the client"; |
192 return RequestStatus::FAILURE; | 195 return RequestStatus::FAILURE; |
193 } | 196 } |
194 | 197 |
195 base::ScopedFD temporary_ipc(fds[0]->Pass()); | 198 base::ScopedFD temporary_ipc(fds[0]->Pass()); |
196 | 199 |
197 Pickle pickle(buf, msg_len); | 200 Pickle pickle(buf, msg_len); |
198 PickleIterator iter(pickle); | 201 PickleIterator iter(pickle); |
199 int command_type; | 202 int command_type; |
200 if (iter.ReadInt(&command_type)) { | 203 if (pickle.ReadInt(&iter, &command_type)) { |
201 bool command_handled = false; | 204 bool command_handled = false; |
202 // Go through all the possible IPC messages. | 205 // Go through all the possible IPC messages. |
203 switch (command_type) { | 206 switch (command_type) { |
204 case COMMAND_ACCESS: | 207 case COMMAND_ACCESS: |
205 case COMMAND_OPEN: | 208 case COMMAND_OPEN: |
206 // We reply on the file descriptor sent to us via the IPC channel. | 209 // We reply on the file descriptor sent to us via the IPC channel. |
207 command_handled = HandleRemoteCommand( | 210 command_handled = HandleRemoteCommand( |
208 broker_policy_, static_cast<IPCCommand>(command_type), | 211 broker_policy_, static_cast<IPCCommand>(command_type), |
209 temporary_ipc.get(), iter); | 212 temporary_ipc.get(), pickle, iter); |
210 break; | 213 break; |
211 default: | 214 default: |
212 NOTREACHED(); | 215 NOTREACHED(); |
213 break; | 216 break; |
214 } | 217 } |
215 | 218 |
216 if (command_handled) { | 219 if (command_handled) { |
217 return RequestStatus::SUCCESS; | 220 return RequestStatus::SUCCESS; |
218 } else { | 221 } else { |
219 return RequestStatus::FAILURE; | 222 return RequestStatus::FAILURE; |
220 } | 223 } |
221 | 224 |
222 NOTREACHED(); | 225 NOTREACHED(); |
223 } | 226 } |
224 | 227 |
225 LOG(ERROR) << "Error parsing IPC request"; | 228 LOG(ERROR) << "Error parsing IPC request"; |
226 return RequestStatus::FAILURE; | 229 return RequestStatus::FAILURE; |
227 } | 230 } |
228 | 231 |
229 } // namespace syscall_broker | 232 } // namespace syscall_broker |
230 | 233 |
231 } // namespace sandbox | 234 } // namespace sandbox |
OLD | NEW |