Issue 82483002: Clear native pointers when destroy()ing Java objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 82483002: Clear native pointers when destroy()ing Java objects. (Closed)

Created:
7 years, 1 month ago by newt (away)

Modified:
7 years, 1 month ago

Reviewers:
Ted C, David Trainor- moved to gerrit

CC:
chromium-reviews, browser-components-watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clear native pointers when destroy()ing Java objects. We weren't clearing the native pointers for these Java objects, but we were asserting that the native pointers were 0 in the (evil) Java finalizers. This resulted in an error in the logs (but no crash, thanks to the beauty of finalizers). NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236808

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase (you can do it, app engine!) #

Patch Set 4 : uploading is hard, let's go shopping #

Patch Set 5 : I think I can, I think I can, ... #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/ForeignSessionHelper.java	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/82483002/50002

7 years, 1 month ago (2013-11-22 19:25:01 UTC) #4

Message was sent while issue was closed.

Change committed as 236808

Expand Messages | Collapse Messages