chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java - Issue 82483002: Clear native pointers when destroy()ing Java objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java

Issue 82483002: Clear native pointers when destroy()ing Java objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: I think I can, I think I can, ... Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ForeignSessionHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java b/chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java

index 8457d3465058381f80f49be718726b5077ccefc3..f2fdf3f759d0839540c45fd24c9117e591858bb9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/NewTabPagePrefs.java

@@ -11,7 +11,7 @@ import org.chromium.chrome.browser.profiles.Profile;

* This class allows Java code to read and modify preferences related to the NTP

public class NewTabPagePrefs {

- private final long mNativeNewTabPagePrefs;

+ private long mNativeNewTabPagePrefs;

/**

* Initialize this class with the given profile.

@@ -27,6 +27,7 @@ public class NewTabPagePrefs {

public void destroy() {

assert mNativeNewTabPagePrefs != 0;

nativeDestroy(mNativeNewTabPagePrefs);

+ mNativeNewTabPagePrefs = 0;

}

/**