chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java - Issue 82483002: Clear native pointers when destroy()ing Java objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java

Issue 82483002: Clear native pointers when destroy()ing Java objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: I think I can, I think I can, ... Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java

index b929a18bb06e456e8811f4069f1bbacbf9c2d2a9..c2722142eec6daae8e2040031334f23d1542c135 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/favicon/FaviconHelper.java

@@ -57,6 +57,7 @@ public class FaviconHelper {

* Clean up the C++ side of this class. After the call, this class instance shouldn't be used.

public void destroy() {

+ assert mNativeFaviconHelper != 0;

nativeDestroy(mNativeFaviconHelper);

mNativeFaviconHelper = 0;

}

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/RecentlyClosedBridge.java ('k') | no next file » | no next file with comments »