Chromium Code Reviews
Help | Chromium Project | Sign in
(89)

Issue 8232032: Fix chrome_tests.gypi to depend up on d8#host and use d8 when generating c++ code from js. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by Sheridan Rawlins
Modified:
3 years, 8 months ago
CC:
chromium-reviews, Yang
Visibility:
Public.

Description

Fix chrome_tests.gypi to depend up on d8#host and use d8 when generating c++ code from js. BUG=99173 R=jeffbailey@chromium.org TEST=browser_tests --gtest_filter=WebUIAssertionsTest.*

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/chrome_tests.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
Sheridan Rawlins
Jeff, this changes the dependency to use d8 instead of v8_shell as the v8 team ...
3 years, 8 months ago (2011-10-12 06:36:13 UTC) #1
Sheridan Rawlins
3 years, 8 months ago (2011-10-17 21:01:28 UTC) #2
On 2011/10/12 06:36:13, Sheridan Rawlins wrote:
> Jeff, this changes the dependency to use d8 instead of v8_shell as the v8 team
> want to demote the shell to an example and stop maintaining it as a
dependency.

Waiting on v8:1775 - will close.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d