Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4841)

Unified Diff: chrome/chrome_tests.gypi

Issue 8232032: Fix chrome_tests.gypi to depend up on d8#host and use d8 when generating c++ code from js. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index c35c027c210dd782a937ee2539cb09dcff085128..4598a509e93b27eb209127ed10ff06d3b8f8f2b1 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -2230,6 +2230,8 @@
# Runtime dependencies
'../third_party/mesa/mesa.gyp:osmesa',
'../third_party/WebKit/Source/WebKit/chromium/WebKit.gyp:copy_TestNetscapePlugIn',
+ # build time dependency.
+ '../v8/src/d8.gyp:d8#host',
],
'include_dirs': [
'..',
@@ -2536,7 +2538,7 @@
'extension': 'js',
'inputs': [
'<(gypv8sh)',
- '<(PRODUCT_DIR)/v8_shell<(EXECUTABLE_SUFFIX)',
+ '<(PRODUCT_DIR)/d8<(EXECUTABLE_SUFFIX)',
'<(mock_js)',
'<(test_api_js)',
'<(js2webui)',
@@ -2743,8 +2745,6 @@
}],
['target_arch!="arm"', {
'dependencies': [
- # build time dependency.
- '../v8/tools/gyp/v8.gyp:v8_shell#host',
# run time dependency
'../webkit/webkit.gyp:copy_npapi_test_plugin',
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698