Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: src/gpu/effects/GrDistanceFieldTextureEffect.cpp

Issue 822423004: Move most of the transform logic into the primitive processors (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: tiny update Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/effects/GrDistanceFieldTextureEffect.cpp
diff --git a/src/gpu/effects/GrDistanceFieldTextureEffect.cpp b/src/gpu/effects/GrDistanceFieldTextureEffect.cpp
index 21fbb307c1eeeec8d66323abc7a5bf94c708dc97..1e6155fd38b0817fd421df7bc193079c656327b5 100755
--- a/src/gpu/effects/GrDistanceFieldTextureEffect.cpp
+++ b/src/gpu/effects/GrDistanceFieldTextureEffect.cpp
@@ -35,7 +35,7 @@ public:
#endif
{}
- virtual void emitCode(const EmitArgs& args) SK_OVERRIDE {
+ virtual void emitCode(EmitArgs& args) SK_OVERRIDE {
const GrDistanceFieldTextureEffect& dfTexEffect =
args.fGP.cast<GrDistanceFieldTextureEffect>();
const DistanceFieldBatchTracker& local = args.fBT.cast<DistanceFieldBatchTracker>();
@@ -45,6 +45,10 @@ public:
GrGLFragmentShaderBuilder::kStandardDerivatives_GLSLFeature));
GrGLVertexBuilder* vsBuilder = args.fPB->getVertexShaderBuilder();
+
+ // emit attributes
+ vsBuilder->emitAttributes(dfTexEffect);
+
GrGLVertToFrag v(kVec2f_GrSLType);
args.fPB->addVarying("TextureCoords", &v);
vsBuilder->codeAppendf("%s = %s;", v.vsOut(), dfTexEffect.inTextureCoords()->fName);
@@ -56,16 +60,18 @@ public:
// setup uniform viewMatrix
this->addUniformViewMatrix(pb);
- // setup position varying
- vsBuilder->codeAppendf("%s = %s * vec3(%s, 1);", vsBuilder->glPosition(),
- this->uViewM(), dfTexEffect.inPosition()->fName);
-
- // setup output coords
- vsBuilder->codeAppendf("%s = %s;", vsBuilder->positionCoords(),
- dfTexEffect.inPosition()->fName);
- vsBuilder->codeAppendf("%s = %s;", vsBuilder->localCoords(),
+ // Setup position
+ const char* pos3 = "pos3";
+ vsBuilder->codeAppendf("vec3 %s;", pos3);
+ vsBuilder->codeAppendf("%s = %s * vec3(%s, 1);", pos3, this->uViewM(),
dfTexEffect.inPosition()->fName);
+ // emit transforms
+ this->emitTransforms(args.fPB, pos3, dfTexEffect.inPosition()->fName,
+ dfTexEffect.localMatrix(), args.fTransformsIn, args.fTransformsOut);
+
+ vsBuilder->transformToNormalizedDeviceSpace(pos3);
+
const char* textureSizeUniName = NULL;
fTextureSizeUni = args.fPB->addUniform(GrGLProgramBuilder::kFragment_Visibility,
kVec2f_GrSLType, kDefault_GrSLPrecision,
@@ -242,8 +248,9 @@ void GrDistanceFieldTextureEffect::getGLProcessorKey(const GrBatchTracker& bt,
GrGLDistanceFieldTextureEffect::GenKey(*this, bt, caps, b);
}
-GrGLGeometryProcessor*
-GrDistanceFieldTextureEffect::createGLInstance(const GrBatchTracker& bt) const {
+GrGLPrimitiveProcessor*
+GrDistanceFieldTextureEffect::createGLInstance(const GrBatchTracker& bt,
+ const GrGLCaps&) const {
return SkNEW_ARGS(GrGLDistanceFieldTextureEffect, (*this, bt));
}
@@ -321,7 +328,7 @@ public:
const GrBatchTracker&)
: fColor(GrColor_ILLEGAL), fTextureSize(SkISize::Make(-1, -1)) {}
- virtual void emitCode(const EmitArgs& args) SK_OVERRIDE {
+ virtual void emitCode(EmitArgs& args) SK_OVERRIDE {
const GrDistanceFieldNoGammaTextureEffect& dfTexEffect =
args.fGP.cast<GrDistanceFieldNoGammaTextureEffect>();
@@ -333,6 +340,10 @@ public:
GrGLFragmentShaderBuilder::kStandardDerivatives_GLSLFeature));
GrGLVertexBuilder* vsBuilder = args.fPB->getVertexShaderBuilder();
+
+ // emit attributes
+ vsBuilder->emitAttributes(dfTexEffect);
+
GrGLVertToFrag v(kVec2f_GrSLType);
args.fPB->addVarying("TextureCoords", &v);
@@ -342,18 +353,20 @@ public:
vsBuilder->codeAppendf("%s = %s;", v.vsOut(), dfTexEffect.inTextureCoords()->fName);
- // setup coord outputs
- vsBuilder->codeAppendf("%s = %s;", vsBuilder->positionCoords(),
- dfTexEffect.inPosition()->fName);
- vsBuilder->codeAppendf("%s = %s;", vsBuilder->localCoords(),
- dfTexEffect.inPosition()->fName);
-
// setup uniform viewMatrix
this->addUniformViewMatrix(pb);
- // setup position varying
- vsBuilder->codeAppendf("%s = %s * vec3(%s, 1);", vsBuilder->glPosition(),
- this->uViewM(), dfTexEffect.inPosition()->fName);
+ // Setup position
+ const char* pos3 = "pos3";
+ vsBuilder->codeAppendf("vec3 %s;", pos3);
+ vsBuilder->codeAppendf("%s = %s * vec3(%s, 1);", pos3, this->uViewM(),
+ dfTexEffect.inPosition()->fName);
+
+ // emit transforms
+ this->emitTransforms(args.fPB, pos3, dfTexEffect.inPosition()->fName,
+ dfTexEffect.localMatrix(), args.fTransformsIn, args.fTransformsOut);
+
+ vsBuilder->transformToNormalizedDeviceSpace(pos3);
const char* textureSizeUniName = NULL;
fTextureSizeUni = args.fPB->addUniform(GrGLProgramBuilder::kFragment_Visibility,
@@ -493,8 +506,9 @@ void GrDistanceFieldNoGammaTextureEffect::getGLProcessorKey(const GrBatchTracker
GrGLDistanceFieldNoGammaTextureEffect::GenKey(*this, bt, caps, b);
}
-GrGLGeometryProcessor*
-GrDistanceFieldNoGammaTextureEffect::createGLInstance(const GrBatchTracker& bt) const {
+GrGLPrimitiveProcessor*
+GrDistanceFieldNoGammaTextureEffect::createGLInstance(const GrBatchTracker& bt,
+ const GrGLCaps&) const {
return SkNEW_ARGS(GrGLDistanceFieldNoGammaTextureEffect, (*this, bt));
}
@@ -562,13 +576,17 @@ public:
, fTextureSize(SkISize::Make(-1,-1))
, fTextColor(GrColor_ILLEGAL) {}
- virtual void emitCode(const EmitArgs& args) SK_OVERRIDE {
+ virtual void emitCode(EmitArgs& args) SK_OVERRIDE {
const GrDistanceFieldLCDTextureEffect& dfTexEffect =
args.fGP.cast<GrDistanceFieldLCDTextureEffect>();
const DistanceFieldLCDBatchTracker& local = args.fBT.cast<DistanceFieldLCDBatchTracker>();
GrGLGPBuilder* pb = args.fPB;
GrGLVertexBuilder* vsBuilder = args.fPB->getVertexShaderBuilder();
+
+ // emit attributes
+ vsBuilder->emitAttributes(dfTexEffect);
+
GrGLVertToFrag v(kVec2f_GrSLType);
args.fPB->addVarying("TextureCoords", &v);
vsBuilder->codeAppendf("%s = %s;", v.vsOut(), dfTexEffect.inTextureCoords()->fName);
@@ -577,19 +595,21 @@ public:
this->setupColorPassThrough(pb, local.fInputColorType, args.fOutputColor, NULL,
&fColorUniform);
- // setup coord outputs
- vsBuilder->codeAppendf("%s = %s;", vsBuilder->positionCoords(),
- dfTexEffect.inPosition()->fName);
- vsBuilder->codeAppendf("%s = %s;", vsBuilder->localCoords(),
- dfTexEffect.inPosition()->fName);
-
// setup uniform viewMatrix
this->addUniformViewMatrix(pb);
- // setup position varying
- vsBuilder->codeAppendf("%s = %s * vec3(%s, 1);", vsBuilder->glPosition(), this->uViewM(),
+ // Setup position
+ const char* pos3 = "pos3";
+ vsBuilder->codeAppendf("vec3 %s;", pos3);
+ vsBuilder->codeAppendf("%s = %s * vec3(%s, 1);", pos3, this->uViewM(),
dfTexEffect.inPosition()->fName);
+ // emit transforms
+ this->emitTransforms(args.fPB, pos3, dfTexEffect.inPosition()->fName,
+ dfTexEffect.localMatrix(), args.fTransformsIn, args.fTransformsOut);
+
+ vsBuilder->transformToNormalizedDeviceSpace(pos3);
+
const char* textureSizeUniName = NULL;
// width, height, 1/(3*width)
fTextureSizeUni = args.fPB->addUniform(GrGLProgramBuilder::kFragment_Visibility,
@@ -805,8 +825,9 @@ void GrDistanceFieldLCDTextureEffect::getGLProcessorKey(const GrBatchTracker& bt
GrGLDistanceFieldLCDTextureEffect::GenKey(*this, bt, caps, b);
}
-GrGLGeometryProcessor*
-GrDistanceFieldLCDTextureEffect::createGLInstance(const GrBatchTracker& bt) const {
+GrGLPrimitiveProcessor*
+GrDistanceFieldLCDTextureEffect::createGLInstance(const GrBatchTracker& bt,
+ const GrGLCaps&) const {
return SkNEW_ARGS(GrGLDistanceFieldLCDTextureEffect, (*this, bt));
}

Powered by Google App Engine
This is Rietveld 408576698