ICU upgrade to 54.1 step 2

ICU upgrade to 54.1 step 2

Update the following patches and apply to the fresh copy of icu 54.1:

  configure.patch
  declspec.patch
  locid.patch
  platform_nacl.patch
  regex.patch
  wpo.patch
  vscomp.patch: two chunks are not necessary any more; upstream has
                them.
  data.build.patch
  data.build_win.patch

Delete the following patches:
  putil.patch: not necessary any more; upstream has it.
  regex2.patch: merged to regex.patch.
  col.patch: not necessary any more; upstream code changed drastically
             and does not have a bug any more.
  clang_win.patch: not necessary any more; upstream has it.

BUG=428145
TEST=None
R=mark@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/icu/+/5580ad69a4f2a2153ef856726faeefd18d8736b3

[jungshik at Google, 2015-01-09 22:12:04]

jshin@chromium.org changed reviewers:
+ mark@chromium.org

[jungshik at Google, 2015-01-09 22:12:05]

Hi Mark, 

I'm updating ICU to 54.1. The fresh copy (along with updated icu.gyp[i]) of 54.1
was landed in the previous cl. [1] This is the first of several steps to apply
our local changes on top of the upstream copy and will be followed by 5 ~ 6 CLs.



[1]
With a new git repo for ICU (made possible by mmoss@), I'm doing an in-place
update and rietveld can't cope with so many files in a single CL so that I ended
up landing it w/o a review.

[Mark Mentovai, 2015-01-09 22:17:40]

LGTM.

I’m glad to see that many changes were taken upstream.

https://codereview.chromium.org/822213003/diff/40001/README.chromium
File README.chromium (right):

https://codereview.chromium.org/822213003/diff/40001/README.chromium#newcode234
README.chromium:234: - upstream bugs :
http://bugs.icu-project.org/trac/ticket/11370 (r36723:36724)
Can you massage this a little bit so it doesn’t go past 80 columns?

https://codereview.chromium.org/822213003/diff/40001/source/common/unicode/ut...
File source/common/unicode/utypes.h (right):

https://codereview.chromium.org/822213003/diff/40001/source/common/unicode/ut...
source/common/unicode/utypes.h:308: #define U_DATA_API     U_EXPORT
Double-check this. Have they made it so that data is always part of the common
library now?

[jungshik at Google, 2015-01-09 23:33:22]

Thank you for the approval. 

I could have dropped more patches (if I had been more diligent in landing our
patches in the upstream :-)). 

As for U_DATA_API, see below. It looks like we can drop the change.

https://codereview.chromium.org/822213003/diff/40001/source/common/unicode/ut...
File source/common/unicode/utypes.h (right):

https://codereview.chromium.org/822213003/diff/40001/source/common/unicode/ut...
source/common/unicode/utypes.h:308: #define U_DATA_API     U_EXPORT
On 2015/01/09 22:17:39, Mark Mentovai wrote:
> Double-check this. Have they made it so that data is always part of the common
> library now?

It's done for this bug :
https://code.google.com/p/chromium/issues/detail?id=325982, but it's not likely
to be relevant any more because we don't use 'icudt.dll' any more (although it's
supported, it's not used by default and none of our bots/release builds uses
it). 

wfh@ has the following analysis : 

---------
I think this is because of a clash in the __declspec(dllimport) udata.cc
declaration of the icudt46.dat import on line 613:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/icu/so...

and the declaration in the .dll that's built and checked in
icu/windows/icudt.dll
-----------

We may as well drop the patch.

[jungshik at Google, 2015-01-12 21:00:49]

Committed patchset #4 (id:60001) manually as
5580ad69a4f2a2153ef856726faeefd18d8736b3 (presubmit successful).