ICU upgrade to 54.1 step 2

source/common/unicode/utypes.h

 /*
 **********************************************************************
 *   Copyright (C) 1996-2014, International Business Machines
 *   Corporation and others.  All Rights Reserved.
 **********************************************************************
 *
 *  FILE NAME : UTYPES.H (formerly ptypes.h)
 *
 *   Date        Name        Description
 *   12/11/96    helena      Creation.
@@ skipping 287 matching lines @@
 #define U_TOOLUTIL_API U_EXPORT
 #elif defined(U_STATIC_IMPLEMENTATION)
 #define U_DATA_API
 #define U_COMMON_API
 #define U_I18N_API
 #define U_LAYOUT_API
 #define U_LAYOUTEX_API
 #define U_IO_API
 #define U_TOOLUTIL_API
 #elif defined(U_COMMON_IMPLEMENTATION)
-#define U_DATA_API     U_IMPORT
+#define U_DATA_API     U_EXPORT

[Mark Mentovai, 2015/01/09 22:17:39]

Double-check this. Have they made it so that data is always part of the common
library now?

[jungshik at Google, 2015/01/09 23:33:22]

It's done for this bug :
https://code.google.com/p/chromium/issues/detail?id=325982, but it's not likely
to be relevant any more because we don't use 'icudt.dll' any more (although it's
supported, it's not used by default and none of our bots/release builds uses
it). 

wfh@ has the following analysis : 

---------
I think this is because of a clash in the __declspec(dllimport) udata.cc
declaration of the icudt46.dat import on line 613:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/icu/so...

and the declaration in the .dll that's built and checked in
icu/windows/icudt.dll
-----------

We may as well drop the patch.

 #define U_COMMON_API   U_EXPORT
 #define U_I18N_API     U_IMPORT
 #define U_LAYOUT_API   U_IMPORT
 #define U_LAYOUTEX_API U_IMPORT
 #define U_IO_API       U_IMPORT
 #define U_TOOLUTIL_API U_IMPORT
 #elif defined(U_I18N_IMPLEMENTATION)
 #define U_DATA_API     U_IMPORT
 #define U_COMMON_API   U_IMPORT
 #define U_I18N_API     U_EXPORT
@@ skipping 321 matching lines @@
     U_REGEX_INVALID_BACK_REF,             /**< Back-reference to a non-existent capture group.    */
     U_REGEX_INVALID_FLAG,                 /**< Invalid value for match mode flags.                */
     U_REGEX_LOOK_BEHIND_LIMIT,            /**< Look-Behind pattern matches must have a bounded maximum length.    */
     U_REGEX_SET_CONTAINS_STRING,          /**< Regexps cannot have UnicodeSets containing strings.*/
     U_REGEX_OCTAL_TOO_BIG,                /**< Octal character constants must be <= 0377. @deprecated ICU 54. This error cannot occur. */
     U_REGEX_MISSING_CLOSE_BRACKET,        /**< Missing closing bracket on a bracket expression.   */
     U_REGEX_INVALID_RANGE,                /**< In a character range [x-y], x is greater than y.   */
     U_REGEX_STACK_OVERFLOW,               /**< Regular expression backtrack stack overflow.       */
     U_REGEX_TIME_OUT,                     /**< Maximum allowed match time exceeded                */
     U_REGEX_STOPPED_BY_CALLER,            /**< Matching operation aborted by user callback fn.    */
+    U_REGEX_PATTERN_TOO_BIG,              /**< Pattern exceeds limits on size or complexity.   @draft ICU 55   */
     U_REGEX_ERROR_LIMIT,                  /**< This must always be the last value to indicate the limit for regexp errors */
 
     /*
      * The error code in the range 0x10400-0x104ff are reserved for IDNA related error codes
      */
     U_IDNA_PROHIBITED_ERROR=0x10400,
     U_IDNA_ERROR_START=0x10400,
     U_IDNA_UNASSIGNED_ERROR,
     U_IDNA_CHECK_BIDI_ERROR,
     U_IDNA_STD3_ASCII_RULES_ERROR,
@@ skipping 54 matching lines @@
  * Return a string for a UErrorCode value.
  * The string will be the same as the name of the error code constant
  * in the UErrorCode enum above.
  * @stable ICU 2.0
  */
 U_STABLE const char * U_EXPORT2
 u_errorName(UErrorCode code);
 
 
 #endif /* _UTYPES */