Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Side by Side Diff: patches/data.build.patch

Issue 822213003: ICU upgrade to 54.1 step 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: readme: better wrapping, declspec patch dropped Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « patches/configure.patch ('k') | patches/data.build.win.patch » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Index: source/data/Makefile.in 1 diff --git a/source/data/Makefile.in b/source/data/Makefile.in
2 =================================================================== 2 index b1b3b36..380cc1a 100644
3 --- source/data/Makefile.in» (revision 259715) 3 --- a/source/data/Makefile.in
4 +++ source/data/Makefile.in» (working copy) 4 +++ b/source/data/Makefile.in
5 @@ -240,7 +240,14 @@ 5 @@ -246,7 +246,8 @@ package390: $(OUTTMPDIR)/icudata390.lst $(PKGDATA_LIST) ./ic upkg.inc packagedata
6 # 2010-dec Removed pnames.icu. 6 # 2010-dec Removed pnames.icu.
7 # These are now hardcoded in ICU4C and only loaded in ICU4J. 7 # These are now hardcoded in ICU4C and only loaded in ICU4J.
8 # 8 #
9 -DAT_FILES_SHORT=unames.icu cnvalias.icu coll/ucadata.icu coll/invuca.icu nfc.nr m nfkc.nrm nfkc_cf.nrm uts46.nrm 9 -DAT_FILES_SHORT=unames.icu cnvalias.icu coll/ucadata.icu nfkc.nrm nfkc_cf.nrm u ts46.nrm
10 +# CHROME: unames.icu is excluded from the data file. 10 +# Chromium: Drop unames.icu because we don't need Unicode character names.
11 +# coll/invuca.icu is also excluded. When building a ICU data file to check in, 11 +DAT_FILES_SHORT=cnvalias.icu coll/ucadata.icu nfkc.nrm nfkc_cf.nrm uts46.nrm
12 +# we need to copy data/in/coll/invuca.icu to the build location (expected
13 +# by genrb : out/build/icudt46l/coll) by hand because genrb requires its
14 +# presence when compiling coll/root.txt. We have to put it back if Webkit
15 +# begins to use it.
16 +# See https://bugs.webkit.org/show_bug.cgi?id=30437#c32 about invuca.icu.
17 +DAT_FILES_SHORT=cnvalias.icu coll/ucadata.icu nfc.nrm nfkc.nrm nfkc_cf.nrm uts4 6.nrm
18 DAT_FILES=$(DAT_FILES_SHORT:%=$(BUILDDIR)/%) 12 DAT_FILES=$(DAT_FILES_SHORT:%=$(BUILDDIR)/%)
19 13
20 ## BRK files 14 ## BRK files
21 @@ -271,7 +278,8 @@ 15 @@ -277,7 +278,8 @@ CFU_FILES=$(BUILDDIR)/$(CFU_FILES_SHORT)
22 -include $(UCMSRCDIR)/ucmfiles.mk 16 -include $(UCMSRCDIR)/ucmfiles.mk
23 -include $(UCMSRCDIR)/ucmebcdic.mk 17 -include $(UCMSRCDIR)/ucmebcdic.mk
24 -include $(UCMSRCDIR)/ucmlocal.mk 18 -include $(UCMSRCDIR)/ucmlocal.mk
25 -ALL_UCM_SOURCE=ibm-37_P100-1995.ucm ibm-1047_P100-1995.ucm $(UCM_SOURCE_CORE) $ (UCM_SOURCE_FILES) $(UCM_SOURCE_EBCDIC) $(UCM_SOURCE_LOCAL) 19 -ALL_UCM_SOURCE=ibm-37_P100-1995.ucm ibm-1047_P100-1995.ucm $(UCM_SOURCE_CORE) $ (UCM_SOURCE_FILES) $(UCM_SOURCE_EBCDIC) $(UCM_SOURCE_LOCAL)
26 +# CHROME: we don't need any EBCDIC converters. 20 +# Chromium: Drop 2 ibm encodings not necessary.
27 +ALL_UCM_SOURCE=$(UCM_SOURCE_CORE) $(UCM_SOURCE_FILES) $(UCM_SOURCE_EBCDIC) $(UC M_SOURCE_LOCAL) 21 +ALL_UCM_SOURCE=$(UCM_SOURCE_CORE) $(UCM_SOURCE_FILES) $(UCM_SOURCE_EBCDIC) $(UC M_SOURCE_LOCAL)
28 UCM_FILES = $(ALL_UCM_SOURCE:%=$(SRCDATADIR)/%) 22 UCM_FILES = $(ALL_UCM_SOURCE:%=$(SRCDATADIR)/%)
29 CNV_FILES = $(ALL_UCM_SOURCE:%.ucm=$(BUILDDIR)/%.cnv) 23 CNV_FILES = $(ALL_UCM_SOURCE:%.ucm=$(BUILDDIR)/%.cnv)
30 CNV_FILES_SHORT = $(ALL_UCM_SOURCE:%.ucm=%.cnv) 24 CNV_FILES_SHORT = $(ALL_UCM_SOURCE:%.ucm=%.cnv)
31 @@ -338,7 +346,8 @@ 25 @@ -529,7 +531,14 @@ $(BUILDDIR)/%.icu: $(SRCDATADIR)/in/%.icu
32 TRANSLIT_SRC_FILES = $(TRANSLIT_SRC:%=$(TRANSLITSRCDIR)/%) 26 $(BUILDDIR)/%.nrm: $(SRCDATADIR)/in/%.nrm
33 INSTALLED_TRANSLIT_FILES = $(TRANSLIT_SOURCE:%.txt=%) $(TRANSLIT_SOURCE_LOCAL: %.txt=%) 27 » $(INVOKE) $(TOOLBINDIR)/icupkg -t$(ICUDATA_CHAR) $< $@
34 endif
35 -GENRBOPTS=-k
36 +# CHROME : To save space, use '-R' option.
37 +GENRBOPTS=-k -R
38 28
39 ## MISC files 29 -$(BUILDDIR)/coll/ucadata.icu: $(SRCDATADIR)/in/coll/ucadata-unihan.icu
40 -include $(MISCSRCDIR)/miscfiles.mk 30 +# Chromium: To cut down the data size by 280kB,
41 Index: source/tools/toolutil/pkg_genc.c 31 +# use the code point order for CJK Ideographs in non-CJK locales instead
42 =================================================================== 32 +# of the UniHan radical-stroke order. The latter is better, but non-CJK
43 --- source/tools/toolutil/pkg_genc.c» (revision 259715) 33 +# locales do not have a great need for sorting CJK Ideographs.
44 +++ source/tools/toolutil/pkg_genc.c» (working copy) 34 +# Moreover, the most common subset (the original CJK Ideograph block) will
45 @@ -119,7 +119,11 @@ 35 +# still be sorted correctly because the code point order is radical-stroke
36 +# order.
37 +$(BUILDDIR)/coll/ucadata.icu: $(SRCDATADIR)/in/coll/ucadata-implicithan.icu
38 » $(INVOKE) $(TOOLBINDIR)/icupkg -t$(ICUDATA_CHAR) $< $@
39
40 #################################################### SPP
41 diff --git a/source/tools/toolutil/pkg_genc.c b/source/tools/toolutil/pkg_genc.c
42 index e211403..ddc6941 100644
43 --- a/source/tools/toolutil/pkg_genc.c
44 +++ b/source/tools/toolutil/pkg_genc.c
45 @@ -119,7 +119,11 @@ static const struct AssemblyType {
46 ".globl %s\n" 46 ".globl %s\n"
47 "\t.section .note.GNU-stack,\"\",%%progbits\n" 47 "\t.section .note.GNU-stack,\"\",%%progbits\n"
48 "\t.section .rodata\n" 48 "\t.section .rodata\n"
49 - "\t.balign 16\n" 49 - "\t.balign 16\n"
50 + "\t.balign 16\n" 50 + "\t.balign 16\n"
51 + /* The 3 lines below are added for Chrome. */ 51 + /* The 3 lines below are added for Chrome. */
52 + "#ifdef U_HIDE_DATA_SYMBOL\n" 52 + "#ifdef U_HIDE_DATA_SYMBOL\n"
53 + "\t.hidden %s\n" 53 + "\t.hidden %s\n"
54 + "#endif\n" 54 + "#endif\n"
55 "\t.type %s,%%object\n" 55 "\t.type %s,%%object\n"
56 "%s:\n\n", 56 "%s:\n\n",
57 57
58 @@ -129,6 +133,10 @@ 58 @@ -129,6 +133,10 @@ static const struct AssemblyType {
59 /*"\t.section __TEXT,__text,regular,pure_instructions\n" 59 /*"\t.section __TEXT,__text,regular,pure_instructions\n"
60 "\t.section __TEXT,__picsymbolstub1,symbol_stubs,pure_instructions,32\n "*/ 60 "\t.section __TEXT,__picsymbolstub1,symbol_stubs,pure_instructions,32\n "*/
61 ".globl _%s\n" 61 ".globl _%s\n"
62 + /* The 3 lines below are added for Chrome. */ 62 + /* The 3 lines below are added for Chrome. */
63 + "#ifdef U_HIDE_DATA_SYMBOL\n" 63 + "#ifdef U_HIDE_DATA_SYMBOL\n"
64 + "\t.private_extern _%s\n" 64 + "\t.private_extern _%s\n"
65 + "#endif\n" 65 + "#endif\n"
66 "\t.data\n" 66 "\t.data\n"
67 "\t.const\n" 67 "\t.const\n"
68 "\t.balign 16\n" 68 "\t.balign 16\n"
69 @@ -264,7 +272,7 @@ 69 @@ -264,7 +272,7 @@ writeAssemblyCode(const char *filename, const char *destdir, const char *optEntr
70 exit(U_FILE_ACCESS_ERROR); 70 exit(U_FILE_ACCESS_ERROR);
71 } 71 }
72 72
73 - getOutFilename(filename, destdir, bufferStr, entry, ".s", optFilename); 73 - getOutFilename(filename, destdir, bufferStr, entry, ".s", optFilename);
74 + getOutFilename(filename, destdir, bufferStr, entry, ".S", optFilename); 74 + getOutFilename(filename, destdir, bufferStr, entry, ".S", optFilename);
75 out=T_FileStream_open(bufferStr, "w"); 75 out=T_FileStream_open(bufferStr, "w");
76 if(out==NULL) { 76 if(out==NULL) {
77 fprintf(stderr, "genccode: unable to open output file %s\n", bufferStr) ; 77 fprintf(stderr, "genccode: unable to open output file %s\n", bufferStr) ;
OLDNEW
« no previous file with comments | « patches/configure.patch ('k') | patches/data.build.win.patch » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698