Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 821693003: replace COMPILE_ASSERT with static_assert in sandbox/ (Closed)

Created:
5 years, 12 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, wfh+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in sandbox/ BUG=442514 Committed: https://crrev.com/7430d7c80a263d3ac861d1c9f1f39a2e15ec4dd8 Cr-Commit-Position: refs/heads/master@{#310165}

Patch Set 1 #

Patch Set 2 : fixup #

Patch Set 3 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -34 lines) Patch
M sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/syscall.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall_iterator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M sandbox/linux/services/credentials.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M sandbox/linux/syscall_broker/broker_file_permission_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/linux/tests/scoped_temporary_file.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/Wow64.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/src/crosscall_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/win/src/crosscall_params.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sandbox/win/src/policy_engine_opcodes.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/win/src/policy_low_level.h View 1 chunk +2 lines, -1 line 0 comments Download
M sandbox/win/src/policy_params.h View 1 chunk +4 lines, -4 lines 0 comments Download
M sandbox/win/src/service_resolver_32.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M sandbox/win/src/sharedmem_ipc_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/wow_helper/wow_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@cpu: please take a look.
5 years, 11 months ago (2015-01-05 22:03:50 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 11 months ago (2015-01-06 21:13:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821693003/40001
5 years, 11 months ago (2015-01-06 21:14:50 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-06 23:04:32 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 23:06:18 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7430d7c80a263d3ac861d1c9f1f39a2e15ec4dd8
Cr-Commit-Position: refs/heads/master@{#310165}

Powered by Google App Engine
This is Rietveld 408576698