sandbox/linux/syscall_broker/broker_file_permission_unittest.cc - Issue 821693003: replace COMPILE_ASSERT with static_assert in sandbox/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/syscall_broker/broker_file_permission_unittest.cc

Issue 821693003: replace COMPILE_ASSERT with static_assert in sandbox/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase on master Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sandbox/linux/syscall_broker/broker_file_permission_unittest.cc

diff --git a/sandbox/linux/syscall_broker/broker_file_permission_unittest.cc b/sandbox/linux/syscall_broker/broker_file_permission_unittest.cc

index 2853021448db8f086ff1ba4596805e48ffdce377..b58a901cde6f8d57be62e3cf1951ceb6a70e0bc1 100644

--- a/sandbox/linux/syscall_broker/broker_file_permission_unittest.cc

+++ b/sandbox/linux/syscall_broker/broker_file_permission_unittest.cc

@@ -124,8 +124,8 @@ void CheckPerm(const BrokerFilePermission& perm,

#endif

const int kNumberOfBitsInOAccMode = 2;

- COMPILE_ASSERT(O_ACCMODE == ((1 << kNumberOfBitsInOAccMode) - 1),

- number_of_bits);

+ static_assert(O_ACCMODE == ((1 << kNumberOfBitsInOAccMode) - 1),

+ "incorrect number of bits");

// check every possible flag and act accordingly.

// Skipping AccMode bits as they are present in every case.

for (int i = kNumberOfBitsInOAccMode; i < 32; i++) {

« no previous file with comments | « sandbox/linux/services/credentials.cc ('k') | sandbox/linux/tests/scoped_temporary_file.cc » ('j') | no next file with comments »