sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc - Issue 821693003: replace COMPILE_ASSERT with static_assert in sandbox/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc

Issue 821693003: replace COMPILE_ASSERT with static_assert in sandbox/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase on master Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc ('k') | sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc

diff --git a/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc b/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc

index 69d32bc18fc91936bd2d030952e76c4f95e0ec16..214b99c7467a6ccc7947b20ef774bc139ca38d53 100644

--- a/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc

+++ b/sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc

@@ -187,7 +187,8 @@ ResultExpr EvaluateSyscallImpl(int fs_denied_errno,

defined(__aarch64__)

if (sysno == __NR_socketpair) {

// Only allow AF_UNIX, PF_UNIX. Crash if anything else is seen.

- COMPILE_ASSERT(AF_UNIX == PF_UNIX, af_unix_pf_unix_different);

+ static_assert(AF_UNIX == PF_UNIX,

+ "af_unix and pf_unix should not be different");

const Arg<int> domain(0);

return If(domain == AF_UNIX, Allow()).Else(CrashSIGSYS());

}