Change 'bool world_readable' to an enum

util/file/file_io_posix.cc

Index: util/file/file_io_posix.cc
diff --git a/util/file/file_io_posix.cc b/util/file/file_io_posix.cc
index fbfdad0837368d776b51b55a8372a3400fb166d9..d2b2cbbe95bf1cc0d84169f5fc9b26f6c8e0b4ef 100644
--- a/util/file/file_io_posix.cc
+++ b/util/file/file_io_posix.cc
@@ -84,7 +84,7 @@ FileHandle LoggingOpenFileForRead(const base::FilePath& path) {
 
 FileHandle LoggingOpenFileForWrite(const base::FilePath& path,
                                    FileWriteMode mode,
-                                   bool world_readable) {
+                                   FilePermissions permissions) {
   int flags = O_WRONLY | O_CREAT;
   // kReuseOrCreate does not need any additional flags.
   if (mode == FileWriteMode::kTruncateOrCreate)
@@ -93,7 +93,8 @@ FileHandle LoggingOpenFileForWrite(const base::FilePath& path,
     flags |= O_EXCL;
 
   int fd = HANDLE_EINTR(
-      open(path.value().c_str(), flags, world_readable ? 0644 : 0600));
+      open(path.value().c_str(), flags,

[Mark Mentovai, 2014/12/19 23:26:33]

Personally, I don’t like the way clang-format does these now, where different
lines have different numbers of arguments, because it makes the arguments harder
to find. But I won’t fight clang-format if you want to keep it as-is.

[scottmg, 2014/12/19 23:33:14]

I also dislike this format, but was following what .clang-format said. I'll
switch and send a follow up to fix .clang-format.

+           permissions == FilePermissions::kWorldReadable ? 0644 : 0600));
   PLOG_IF(ERROR, fd < 0) << "open " << path.value();
   return fd;
 }