util/file/file_io_win.cc - Issue 821483002: Change 'bool world_readable' to an enum

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/file/file_io_win.cc

Issue 821483002: Change 'bool world_readable' to an enum (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/file/file_io_win.cc

diff --git a/util/file/file_io_win.cc b/util/file/file_io_win.cc

index 9106ab0bd32f5693d1cbabf31e67ddf4b193af34..861f15acc64e2243c2b5d024bc68f7b947ff15e4 100644

--- a/util/file/file_io_win.cc

+++ b/util/file/file_io_win.cc

@@ -83,7 +83,7 @@ FileHandle LoggingOpenFileForRead(const base::FilePath& path) {

FileHandle LoggingOpenFileForWrite(const base::FilePath& path,

FileWriteMode mode,

- bool world_readable) {

+ FilePermissions permissions) {

DWORD disposition = 0;

switch (mode) {

case FileWriteMode::kReuseOrCreate: