Change 'bool world_readable' to an enum

util/file/file_io_posix.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 66 matching lines @@
 }
 
 FileHandle LoggingOpenFileForRead(const base::FilePath& path) {
   int fd = HANDLE_EINTR(open(path.value().c_str(), O_RDONLY));
   PLOG_IF(ERROR, fd < 0) << "open " << path.value();
   return fd;
 }
 
 FileHandle LoggingOpenFileForWrite(const base::FilePath& path,
                                    FileWriteMode mode,
-                                   bool world_readable) {
+                                   FilePermissions permissions) {
   int flags = O_WRONLY | O_CREAT;
   // kReuseOrCreate does not need any additional flags.
   if (mode == FileWriteMode::kTruncateOrCreate)
     flags |= O_TRUNC;
   else if (mode == FileWriteMode::kCreateOrFail)
     flags |= O_EXCL;
 
   int fd = HANDLE_EINTR(
-      open(path.value().c_str(), flags, world_readable ? 0644 : 0600));
+      open(path.value().c_str(), flags,

[Mark Mentovai, 2014/12/19 23:26:33]

Personally, I don’t like the way clang-format does these now, where different
lines have different numbers of arguments, because it makes the arguments harder
to find. But I won’t fight clang-format if you want to keep it as-is.

[scottmg, 2014/12/19 23:33:14]

I also dislike this format, but was following what .clang-format said. I'll
switch and send a follow up to fix .clang-format.

+           permissions == FilePermissions::kWorldReadable ? 0644 : 0600));
   PLOG_IF(ERROR, fd < 0) << "open " << path.value();
   return fd;
 }
 
 FileOffset LoggingSeekFile(FileHandle file, FileOffset offset, int whence) {
   off_t rv = lseek(file, offset, whence);
   PLOG_IF(ERROR, rv < 0) << "lseek";
   return rv;
 }
 
 bool LoggingCloseFile(FileHandle file) {
   int rv = IGNORE_EINTR(close(file));
   PLOG_IF(ERROR, rv != 0) << "close";
   return rv == 0;
 }
 
 }  // namespace crashpad