Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 821243003: removing coord change matrices (Closed)

Created:
6 years ago by joshua.litt
Modified:
5 years, 11 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@no-coordchange-on-drawstate
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

removing coord change matrices BUG=skia: Committed: https://skia.googlesource.com/skia/+/40d4bd8dafe9ed844f29a3de3d8965672248ee73

Patch Set 1 #

Patch Set 2 : tiny nit #

Patch Set 3 : one more cleanup #

Total comments: 1

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -197 lines) Patch
M include/gpu/GrFragmentStage.h View 1 chunk +7 lines, -106 lines 0 comments Download
M include/gpu/GrPaint.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 2 chunks +3 lines, -18 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrPaint.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrPendingFragmentStage.h View 1 1 chunk +4 lines, -17 lines 0 comments Download
M src/gpu/GrProcOptInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 5 chunks +7 lines, -19 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLLegacyNvprProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLNvprProgramBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 2 3 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
joshualitt
6 years ago (2014-12-23 17:30:27 UTC) #2
bsalomon
hallelujah lgtm https://codereview.chromium.org/821243003/diff/40001/include/gpu/GrFragmentStage.h File include/gpu/GrFragmentStage.h (left): https://codereview.chromium.org/821243003/diff/40001/include/gpu/GrFragmentStage.h#oldcode26 include/gpu/GrFragmentStage.h:26: GrFragmentStage(const GrFragmentStage& other) { wooooooooooo!
5 years, 11 months ago (2014-12-29 14:23:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821243003/60001
5 years, 11 months ago (2014-12-29 16:55:44 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2014-12-29 17:04:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/40d4bd8dafe9ed844f29a3de3d8965672248ee73

Powered by Google App Engine
This is Rietveld 408576698