Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 819653006: Attach QuicAckNotifiers to the serialized packet, instead of individual (Closed)

Created:
5 years, 11 months ago by ramant (doing other things)
Modified:
5 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, rjshade
Base URL:
https://chromium.googlesource.com/chromium/src.git@removing_deprecated_flag_83439062
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attach QuicAckNotifiers to the serialized packet, instead of individual stream frames. Protected behind FLAGS_quic_attach_ack_notifiers_to_packets. A call to QuicPacketGenerator::ConsumeData may result in multiple stream frames, in multiple packets, being created to hold the data. Previously the QuicAckNotifier was attached to each *frame*, but really it should be attached to the serialized *packet* as the notifier is interested in knowing when the *packet* gets ACKed. No behavior change intended. Added an end to end test demonstrating that the AckNotifier works in the face of 30% packet loss. Earlier rch and I were sceptical this refactor would work with retransmissions, but the QuicAckNotifierManager still recieves calls to UpdateSequenceNumber and does the right thing. Merge internal change: 83452063 R=rch@chromium.org

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -28 lines) Patch
M net/quic/quic_ack_notifier.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/quic_ack_notifier_manager.cc View 2 chunks +40 lines, -20 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 2 chunks +14 lines, -1 line 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +69 lines, -0 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 1 chunk +8 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
ramant (doing other things)
5 years, 11 months ago (2015-01-10 00:53:39 UTC) #1
Ryan Hamilton
5 years, 11 months ago (2015-01-10 01:24:19 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698