|
Attach QuicAckNotifiers to the serialized packet, instead of individual
stream frames.
Protected behind FLAGS_quic_attach_ack_notifiers_to_packets.
A call to QuicPacketGenerator::ConsumeData may result in multiple stream
frames, in multiple packets, being created to hold the data. Previously
the QuicAckNotifier was attached to each *frame*, but really it should
be attached to the serialized *packet* as the notifier is interested in
knowing when the *packet* gets ACKed.
No behavior change intended.
Added an end to end test demonstrating that the AckNotifier works in the
face of 30% packet loss. Earlier rch and I were sceptical this refactor
would work with retransmissions, but the QuicAckNotifierManager still
recieves calls to UpdateSequenceNumber and does the right thing.
Merge internal change: 83452063
R=rch@chromium.org
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+167 lines, -28 lines) |
Patch |
 |
M |
net/quic/quic_ack_notifier.cc
|
View
|
|
2 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
net/quic/quic_ack_notifier_manager.cc
|
View
|
|
2 chunks |
+40 lines, -20 lines |
0 comments
|
Download
|
 |
M |
net/quic/quic_flags.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
net/quic/quic_flags.cc
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
net/quic/quic_packet_generator.h
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
net/quic/quic_packet_generator.cc
|
View
|
|
2 chunks |
+14 lines, -1 line |
0 comments
|
Download
|
 |
M |
net/quic/quic_protocol.h
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
net/quic/quic_sent_packet_manager.cc
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
 |
M |
net/tools/quic/end_to_end_test.cc
|
View
|
|
1 chunk |
+69 lines, -0 lines |
0 comments
|
Download
|
 |
M |
net/tools/quic/quic_spdy_client_stream.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
net/tools/quic/quic_spdy_client_stream.cc
|
View
|
|
1 chunk |
+8 lines, -1 line |
0 comments
|
Download
|
 |
M |
net/tools/quic/test_tools/quic_test_client.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
net/tools/quic/test_tools/quic_test_client.cc
|
View
|
|
1 chunk |
+7 lines, -1 line |
0 comments
|
Download
|
Total messages: 3 (1 generated)
|