Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Side by Side Diff: net/quic/quic_ack_notifier.cc

Issue 819653006: Attach QuicAckNotifiers to the serialized packet, instead of individual (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@removing_deprecated_flag_83439062
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/quic_ack_notifier_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_ack_notifier.h" 5 #include "net/quic/quic_ack_notifier.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 26 matching lines...) Expand all
37 QuicAckNotifier::~QuicAckNotifier() { 37 QuicAckNotifier::~QuicAckNotifier() {
38 } 38 }
39 39
40 void QuicAckNotifier::AddSequenceNumber( 40 void QuicAckNotifier::AddSequenceNumber(
41 const QuicPacketSequenceNumber& sequence_number, 41 const QuicPacketSequenceNumber& sequence_number,
42 int packet_payload_size) { 42 int packet_payload_size) {
43 sequence_numbers_.insert(make_pair(sequence_number, 43 sequence_numbers_.insert(make_pair(sequence_number,
44 PacketInfo(packet_payload_size))); 44 PacketInfo(packet_payload_size)));
45 ++original_packet_count_; 45 ++original_packet_count_;
46 original_byte_count_ += packet_payload_size; 46 original_byte_count_ += packet_payload_size;
47
48 DVLOG(1) << "AckNotifier waiting for packet: " << sequence_number;
47 } 49 }
48 50
49 bool QuicAckNotifier::OnAck(QuicPacketSequenceNumber sequence_number, 51 bool QuicAckNotifier::OnAck(QuicPacketSequenceNumber sequence_number,
50 QuicTime::Delta delta_largest_observed) { 52 QuicTime::Delta delta_largest_observed) {
51 DCHECK(ContainsKey(sequence_numbers_, sequence_number)); 53 DCHECK(ContainsKey(sequence_numbers_, sequence_number));
52 sequence_numbers_.erase(sequence_number); 54 sequence_numbers_.erase(sequence_number);
53 if (IsEmpty()) { 55 if (IsEmpty()) {
54 // We have seen all the sequence numbers we were waiting for, trigger 56 // We have seen all the sequence numbers we were waiting for, trigger
55 // callback notification. 57 // callback notification.
56 delegate_->OnAckNotification( 58 delegate_->OnAckNotification(
(...skipping 15 matching lines...) Expand all
72 if (it != sequence_numbers_.end()) { 74 if (it != sequence_numbers_.end()) {
73 packet_info = it->second; 75 packet_info = it->second;
74 sequence_numbers_.erase(it); 76 sequence_numbers_.erase(it);
75 } else { 77 } else {
76 DLOG(DFATAL) << "Old sequence number not found."; 78 DLOG(DFATAL) << "Old sequence number not found.";
77 } 79 }
78 80
79 ++retransmitted_packet_count_; 81 ++retransmitted_packet_count_;
80 retransmitted_byte_count_ += packet_info.packet_payload_size; 82 retransmitted_byte_count_ += packet_info.packet_payload_size;
81 sequence_numbers_.insert(make_pair(new_sequence_number, packet_info)); 83 sequence_numbers_.insert(make_pair(new_sequence_number, packet_info));
84
85 DVLOG(1) << "AckNotifier waiting for packet: " << new_sequence_number
86 << " (retransmitted " << old_sequence_number << ").";
82 } 87 }
83 88
84 }; // namespace net 89 }; // namespace net
OLDNEW
« no previous file with comments | « no previous file | net/quic/quic_ack_notifier_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698