Attach QuicAckNotifiers to the serialized packet, instead of individual

net/quic/quic_packet_generator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_packet_generator.h"
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "net/quic/quic_ack_notifier.h"
 #include "net/quic/quic_fec_group.h"
@@ skipping 165 matching lines @@
 
   int frames_created = 0;
   while (delegate_->ShouldGeneratePacket(NOT_RETRANSMISSION,
                                          HAS_RETRANSMITTABLE_DATA, handshake)) {
     QuicFrame frame;
     size_t bytes_consumed = packet_creator_.CreateStreamFrame(
         id, data, offset + total_bytes_consumed, fin, &frame);
     ++frames_created;
 
     // We want to track which packet this stream frame ends up in.
-    frame.stream_frame->notifier = notifier;
+    if (FLAGS_quic_attach_ack_notifiers_to_packets) {
+      if (notifier != nullptr) {
+        ack_notifiers_.insert(notifier);
+      }
+    } else {
+      frame.stream_frame->notifier = notifier;
+    }
 
     if (!AddFrame(frame)) {
       LOG(DFATAL) << "Failed to add stream frame.";
       // Inability to add a STREAM frame creates an unrecoverable hole in a
       // the stream, so it's best to close the connection.
       delegate_->CloseConnection(QUIC_INTERNAL_ERROR, false);
       delete notifier;
       return QuicConsumedData(0, false);
     }
 
@@ skipping 185 matching lines @@
   bool success = packet_creator_.AddSavedFrame(frame);
   if (success && debug_delegate_) {
     debug_delegate_->OnFrameAddedToPacket(frame);
   }
   return success;
 }
 
 void QuicPacketGenerator::SerializeAndSendPacket() {
   SerializedPacket serialized_packet = packet_creator_.SerializePacket();
   DCHECK(serialized_packet.packet);
+
+  // There may be AckNotifiers interested in this packet.
+  if (FLAGS_quic_attach_ack_notifiers_to_packets) {
+    serialized_packet.notifiers.swap(ack_notifiers_);
+    ack_notifiers_.clear();
+  }
+
   delegate_->OnSerializedPacket(serialized_packet);
   MaybeSendFecPacketAndCloseGroup(false);
 
   // The packet has now been serialized, safe to delete pending frames.
   if (FLAGS_quic_disallow_multiple_pending_ack_frames) {
     pending_ack_frame_.reset();
     pending_feedback_frame_.reset();
     pending_stop_waiting_frame_.reset();
   }
 }
@@ skipping 43 matching lines @@
     packet_creator_.set_connection_id_length(PACKET_8BYTE_CONNECTION_ID);
   }
 }
 
 
 void QuicPacketGenerator::set_encryption_level(EncryptionLevel level) {
   packet_creator_.set_encryption_level(level);
 }
 
 }  // namespace net