Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 819403002: Subzero: Use range-based for loops with llvm::ilist<Inst> lists. (Closed)

Created:
5 years, 12 months ago by Jim Stichnoth
Modified:
5 years, 12 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Use range-based for loops with llvm::ilist<Inst> lists. This reestablishes C++11 features lost after switching to llvm::ilist<> in two previous CLs: https://codereview.chromium.org/709533002/ https://codereview.chromium.org/794923002/ BUG= none R=jfb@chromium.org, jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=29841e84014ccbe7344e00f44ce7695a017de69a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -125 lines) Patch
M src/IceCfg.cpp View 4 chunks +23 lines, -26 lines 0 comments Download
M src/IceCfgNode.cpp View 15 chunks +58 lines, -59 lines 0 comments Download
M src/IceOperand.cpp View 2 chunks +14 lines, -16 lines 0 comments Download
M src/IceRegAlloc.cpp View 2 chunks +10 lines, -12 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 3 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
5 years, 12 months ago (2014-12-23 19:20:12 UTC) #2
JF
lgtm
5 years, 12 months ago (2014-12-23 19:27:33 UTC) #3
jvoung (off chromium)
lgtm
5 years, 12 months ago (2014-12-23 19:39:06 UTC) #4
Jim Stichnoth
5 years, 12 months ago (2014-12-23 20:26:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29841e84014ccbe7344e00f44ce7695a017de69a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698