Subzero: Use range-based for loops with llvm::ilist<Inst> lists.

src/IceOperand.cpp

 //===- subzero/src/IceOperand.cpp - High-level operand implementation -----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements the Operand class and its target-independent
@@ skipping 268 matching lines @@
   }
 
   for (CfgNode *Node : Func->getNodes())
     addNode(Node);
 }
 
 void VariablesMetadata::addNode(CfgNode *Node) {
   if (Func->getNumVariables() >= Metadata.size())
     Metadata.resize(Func->getNumVariables());
 
-  for (auto I = Node->getPhis().begin(), E = Node->getPhis().end(); I != E;
-       ++I) {
-    if (I->isDeleted())
+  for (Inst &I : Node->getPhis()) {
+    if (I.isDeleted())
       continue;
-    if (Variable *Dest = I->getDest()) {
+    if (Variable *Dest = I.getDest()) {
       SizeT DestNum = Dest->getIndex();
       assert(DestNum < Metadata.size());
-      Metadata[DestNum].markDef(Kind, I, Node);
+      Metadata[DestNum].markDef(Kind, &I, Node);
     }
-    for (SizeT SrcNum = 0; SrcNum < I->getSrcSize(); ++SrcNum) {
-      if (const Variable *Var = llvm::dyn_cast<Variable>(I->getSrc(SrcNum))) {
+    for (SizeT SrcNum = 0; SrcNum < I.getSrcSize(); ++SrcNum) {
+      if (const Variable *Var = llvm::dyn_cast<Variable>(I.getSrc(SrcNum))) {
         SizeT VarNum = Var->getIndex();
         assert(VarNum < Metadata.size());
         const bool IsFromDef = false;
         const bool IsImplicit = false;
-        Metadata[VarNum].markUse(Kind, I, Node, IsFromDef, IsImplicit);
+        Metadata[VarNum].markUse(Kind, &I, Node, IsFromDef, IsImplicit);
       }
     }
   }
 
-  for (auto I = Node->getInsts().begin(), E = Node->getInsts().end(); I != E;
-       ++I) {
-    if (I->isDeleted())
+  for (Inst &I : Node->getInsts()) {
+    if (I.isDeleted())
       continue;
     // Note: The implicit definitions (and uses) from InstFakeKill are
     // deliberately ignored.
-    if (Variable *Dest = I->getDest()) {
+    if (Variable *Dest = I.getDest()) {
       SizeT DestNum = Dest->getIndex();
       assert(DestNum < Metadata.size());
-      Metadata[DestNum].markDef(Kind, I, Node);
+      Metadata[DestNum].markDef(Kind, &I, Node);
     }
-    for (SizeT SrcNum = 0; SrcNum < I->getSrcSize(); ++SrcNum) {
-      Operand *Src = I->getSrc(SrcNum);
+    for (SizeT SrcNum = 0; SrcNum < I.getSrcSize(); ++SrcNum) {
+      Operand *Src = I.getSrc(SrcNum);
       SizeT NumVars = Src->getNumVars();
       for (SizeT J = 0; J < NumVars; ++J) {
         const Variable *Var = Src->getVar(J);
         SizeT VarNum = Var->getIndex();
         assert(VarNum < Metadata.size());
         const bool IsFromDef = false;
         const bool IsImplicit = false;
-        Metadata[VarNum].markUse(Kind, I, Node, IsFromDef, IsImplicit);
+        Metadata[VarNum].markUse(Kind, &I, Node, IsFromDef, IsImplicit);
       }
     }
   }
 }
 
 bool VariablesMetadata::isMultiDef(const Variable *Var) const {
   assert(Kind != VMK_Uses);
   if (Var->getIsArg())
     return false;
   if (!isTracked(Var))
@@ skipping 143 matching lines @@
   if (!ALLOW_DUMP)
     return Str;
   if (W.getWeight() == RegWeight::Inf)
     Str << "Inf";
   else
     Str << W.getWeight();
   return Str;
 }
 
 } // end of namespace Ice