Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 819223002: Make callers of CommandLine use it via the base:: namespace. (Closed)

Created:
6 years ago by Avi (use Gerrit)
Modified:
6 years ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, sievers+watch_chromium.org, yukishiino+watch_chromium.org, peter+watch_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org, tdanderson+views_chromium.org, jdduke+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, yfriedman+watch_chromium.org, chromium-apps-reviews_chromium.org, jbudorick+watch_chromium.org, cc-bugs_chromium.org, derat+watch_chromium.org, tdresser+watch_chromium.org, mlamouri+watch-notifications_chromium.org, penghuang+watch_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, klundberg+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, Ian Vollick, tfarina, ozone-reviews_chromium.org, danakj+watch_chromium.org, James Su, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make callers of CommandLine use it via the base:: namespace. Covers testing/, tools/, ui/, and win8/. BUG=422426 TEST=none TBR=ben@chromium.org Committed: https://crrev.com/6b10fd03dd0b8ddb91235c49d3f498fb2002c20d Cr-Commit-Position: refs/heads/master@{#309538}

Patch Set 1 #

Patch Set 2 : win fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -200 lines) Patch
M testing/android/native_test_launcher.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M tools/android/common/daemon.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/android/forwarder/forwarder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/android/forwarder2/device_forwarder_main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/command_check.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_desc.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/gn/command_gen.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/command_help.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_ls.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/command_refs.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/exec_process.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gn/function_exec_script.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/gn_main.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/gn/ninja_build_writer.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M tools/gn/scheduler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tools/gn/setup.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M tools/gn/trace.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/imagediff/image_diff.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/ipc_fuzzer/mutate/generate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/ipc_fuzzer/mutate/message_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/ipc_fuzzer/mutate/mutate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/ipc_fuzzer/replay/replay_process.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M tools/perf/clear_system_cache/clear_system_cache_main.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/set_default_handler/set_default_handler_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/app_list_switches.cc View 3 chunks +12 lines, -8 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/apps_grid_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/bench/bench_main.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_tree_host_x11.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/base/cocoa/remote_layer_api.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/font_helper_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/ime/chromeos/component_extension_ime_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/base/ime/remote_input_method_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/touch/touch_enabled.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/ui_base_switches_util.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M ui/base/win/shell.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor_switches.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/compositor/test/context_factories_for_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/devices/x11/touch_factory_x11.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/gesture_detection/gesture_configuration_aura.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/gfx/display.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/gfx/font_render_params_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/render_text.cc View 1 chunk +9 lines, -6 lines 0 comments Download
M ui/gfx/win/direct_write.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_gl_api_implementation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_implementation_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gl/gl_implementation_x11.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gl/gl_surface.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl_surface_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gl/gpu_switching_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/keyboard/keyboard_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/keyboard_util.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_switches.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/common/display_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/demo/ozone_demo.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/ozone_platform_gbm.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/test/ozone_platform_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform_selection.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/examples/examples_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views_content_client/views_content_main_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/wm/core/window_animations.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/command_execute_impl.cc View 1 2 4 chunks +6 lines, -7 lines 0 comments Download
M win8/delegate_execute/delegate_execute.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M win8/delegate_execute/delegate_execute_operation.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/delegate_execute/delegate_execute_util.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M win8/delegate_execute/delegate_execute_util_unittest.cc View 1 3 chunks +6 lines, -5 lines 0 comments Download
M win8/metro_driver/chrome_url_launch_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M win8/metro_driver/metro_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/test/metro_registration_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M win8/test/test_registrar.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819223002/40001
6 years ago (2014-12-23 05:03:29 UTC) #2
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-23 05:51:53 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-23 05:52:58 UTC) #4
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6b10fd03dd0b8ddb91235c49d3f498fb2002c20d
Cr-Commit-Position: refs/heads/master@{#309538}

Powered by Google App Engine
This is Rietveld 408576698