Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: win8/delegate_execute/delegate_execute_util_unittest.cc

Issue 819223002: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "win8/delegate_execute/delegate_execute_util.h" 5 #include "win8/delegate_execute/delegate_execute_util.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
11 #include "base/strings/stringprintf.h" 11 #include "base/strings/stringprintf.h"
12 #include "base/strings/utf_string_conversions.h" 12 #include "base/strings/utf_string_conversions.h"
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 14
15 namespace { 15 namespace {
16 16
17 static const char kSomeSwitch[] = "some-switch"; 17 static const char kSomeSwitch[] = "some-switch";
18 18
19 } // namespace 19 } // namespace
20 20
21 TEST(DelegateExecuteUtil, CommandLineFromParametersTest) { 21 TEST(DelegateExecuteUtil, CommandLineFromParametersTest) {
22 CommandLine cl(CommandLine::NO_PROGRAM); 22 base::CommandLine cl(base::CommandLine::NO_PROGRAM);
23 23
24 // Empty parameters means empty command-line string. 24 // Empty parameters means empty command-line string.
25 cl = delegate_execute::CommandLineFromParameters(NULL); 25 cl = delegate_execute::CommandLineFromParameters(NULL);
26 EXPECT_EQ(std::wstring(), cl.GetProgram().value()); 26 EXPECT_EQ(std::wstring(), cl.GetProgram().value());
27 EXPECT_EQ(CommandLine::StringType(), cl.GetCommandLineString()); 27 EXPECT_EQ(base::CommandLine::StringType(), cl.GetCommandLineString());
28 28
29 // Parameters with a switch are parsed properly. 29 // Parameters with a switch are parsed properly.
30 cl = delegate_execute::CommandLineFromParameters( 30 cl = delegate_execute::CommandLineFromParameters(
31 base::StringPrintf(L"--%ls", 31 base::StringPrintf(L"--%ls",
32 base::ASCIIToUTF16(kSomeSwitch).c_str()).c_str()); 32 base::ASCIIToUTF16(kSomeSwitch).c_str()).c_str());
33 EXPECT_EQ(std::wstring(), cl.GetProgram().value()); 33 EXPECT_EQ(std::wstring(), cl.GetProgram().value());
34 EXPECT_TRUE(cl.HasSwitch(kSomeSwitch)); 34 EXPECT_TRUE(cl.HasSwitch(kSomeSwitch));
35 } 35 }
36 36
37 TEST(DelegateExecuteUtil, MakeChromeCommandLineTest) { 37 TEST(DelegateExecuteUtil, MakeChromeCommandLineTest) {
38 static const wchar_t kSomeArgument[] = L"http://some.url/"; 38 static const wchar_t kSomeArgument[] = L"http://some.url/";
39 static const wchar_t kOtherArgument[] = L"http://some.other.url/"; 39 static const wchar_t kOtherArgument[] = L"http://some.other.url/";
40 const base::FilePath this_exe(CommandLine::ForCurrentProcess()->GetProgram()); 40 const base::FilePath this_exe(
41 base::CommandLine::ForCurrentProcess()->GetProgram());
41 42
42 CommandLine cl(CommandLine::NO_PROGRAM); 43 base::CommandLine cl(base::CommandLine::NO_PROGRAM);
43 44
44 // Empty params and argument contains only the exe. 45 // Empty params and argument contains only the exe.
45 cl = delegate_execute::MakeChromeCommandLine( 46 cl = delegate_execute::MakeChromeCommandLine(
46 this_exe, 47 this_exe,
47 delegate_execute::CommandLineFromParameters(NULL), 48 delegate_execute::CommandLineFromParameters(NULL),
48 base::string16()); 49 base::string16());
49 EXPECT_EQ(1, cl.argv().size()); 50 EXPECT_EQ(1, cl.argv().size());
50 EXPECT_EQ(this_exe.value(), cl.GetProgram().value()); 51 EXPECT_EQ(this_exe.value(), cl.GetProgram().value());
51 52
52 // Empty params with arg contains the arg. 53 // Empty params with arg contains the arg.
53 cl = delegate_execute::MakeChromeCommandLine( 54 cl = delegate_execute::MakeChromeCommandLine(
54 this_exe, delegate_execute::CommandLineFromParameters(NULL), 55 this_exe, delegate_execute::CommandLineFromParameters(NULL),
55 base::string16(kSomeArgument)); 56 base::string16(kSomeArgument));
56 EXPECT_EQ(2, cl.argv().size()); 57 EXPECT_EQ(2, cl.argv().size());
57 EXPECT_EQ(this_exe.value(), cl.GetProgram().value()); 58 EXPECT_EQ(this_exe.value(), cl.GetProgram().value());
58 EXPECT_EQ(1, cl.GetArgs().size()); 59 EXPECT_EQ(1, cl.GetArgs().size());
59 EXPECT_EQ(base::string16(kSomeArgument), cl.GetArgs()[0]); 60 EXPECT_EQ(base::string16(kSomeArgument), cl.GetArgs()[0]);
60 61
61 // Params with switchs and args plus arg contains the arg. 62 // Params with switchs and args plus arg contains the arg.
62 cl = delegate_execute::MakeChromeCommandLine( 63 cl = delegate_execute::MakeChromeCommandLine(
63 this_exe, delegate_execute::CommandLineFromParameters( 64 this_exe, delegate_execute::CommandLineFromParameters(
64 base::StringPrintf(L"--%ls -- %ls", 65 base::StringPrintf(L"--%ls -- %ls",
65 base::ASCIIToUTF16(kSomeSwitch).c_str(), 66 base::ASCIIToUTF16(kSomeSwitch).c_str(),
66 kOtherArgument).c_str()), 67 kOtherArgument).c_str()),
67 base::string16(kSomeArgument)); 68 base::string16(kSomeArgument));
68 EXPECT_EQ(5, cl.argv().size()); 69 EXPECT_EQ(5, cl.argv().size());
69 EXPECT_EQ(this_exe.value(), cl.GetProgram().value()); 70 EXPECT_EQ(this_exe.value(), cl.GetProgram().value());
70 EXPECT_TRUE(cl.HasSwitch(kSomeSwitch)); 71 EXPECT_TRUE(cl.HasSwitch(kSomeSwitch));
71 CommandLine::StringVector args(cl.GetArgs()); 72 base::CommandLine::StringVector args(cl.GetArgs());
72 EXPECT_EQ(2, args.size()); 73 EXPECT_EQ(2, args.size());
73 EXPECT_NE( 74 EXPECT_NE(
74 args.end(), 75 args.end(),
75 std::find(args.begin(), args.end(), base::string16(kOtherArgument))); 76 std::find(args.begin(), args.end(), base::string16(kOtherArgument)));
76 EXPECT_NE(args.end(), 77 EXPECT_NE(args.end(),
77 std::find(args.begin(), args.end(), base::string16(kSomeArgument))); 78 std::find(args.begin(), args.end(), base::string16(kSomeArgument)));
78 } 79 }
79 80
80 TEST(DelegateExecuteUtil, ParametersFromSwitchTest) { 81 TEST(DelegateExecuteUtil, ParametersFromSwitchTest) {
81 EXPECT_EQ(base::string16(), delegate_execute::ParametersFromSwitch(NULL)); 82 EXPECT_EQ(base::string16(), delegate_execute::ParametersFromSwitch(NULL));
82 EXPECT_EQ(base::string16(L"--some-switch"), 83 EXPECT_EQ(base::string16(L"--some-switch"),
83 delegate_execute::ParametersFromSwitch(kSomeSwitch)); 84 delegate_execute::ParametersFromSwitch(kSomeSwitch));
84 } 85 }
OLDNEW
« no previous file with comments | « win8/delegate_execute/delegate_execute_util.cc ('k') | win8/metro_driver/chrome_url_launch_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698