tools/gn/exec_process.cc - Issue 819223002: Make callers of CommandLine use it via the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/exec_process.cc

Issue 819223002: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/exec_process.cc

diff --git a/tools/gn/exec_process.cc b/tools/gn/exec_process.cc

index 701d87804e3fd895be5d5199069efa2ff25a05c5..5119220bf26c1d39fb0bcd0a2be8d9c8c4467573 100644

--- a/tools/gn/exec_process.cc

+++ b/tools/gn/exec_process.cc

@@ -26,7 +26,7 @@

namespace internal {

#if defined(OS_WIN)

-bool ExecProcess(const CommandLine& cmdline,

+bool ExecProcess(const base::CommandLine& cmdline,

const base::FilePath& startup_dir,

std::string* std_out,

std::string* std_err,

@@ -138,7 +138,7 @@ bool ReadFromPipe(int fd, std::string* output) {

return true;

}

-bool ExecProcess(const CommandLine& cmdline,

+bool ExecProcess(const base::CommandLine& cmdline,

const base::FilePath& startup_dir,

std::string* std_out,

std::string* std_err,

« no previous file with comments | « tools/gn/command_refs.cc ('k') | tools/gn/function_exec_script.cc » ('j') | no next file with comments »