Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 819163002: Add UMA actions for elements on the Hung Renderer Dialog (Closed)

Created:
6 years ago by Will Harris
Modified:
5 years, 9 months ago
Reviewers:
msw, Mark P, sky
CC:
chromium-reviews, tfarina, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA actions for elements on the Hung Renderer Dialog. This will help us diagnose how often this Dialog is appearing with no associated crash report. BUG=436379

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -2 lines) Patch
M chrome/browser/ui/views/hung_renderer_view.cc View 6 chunks +14 lines, -2 lines 2 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Will Harris
PTAL isherman for actions.xml sky for everything else
6 years ago (2014-12-22 20:54:56 UTC) #2
Will Harris
On 2014/12/22 20:54:56, Will Harris wrote: > PTAL > > isherman for actions.xml > sky ...
6 years ago (2014-12-22 23:07:11 UTC) #4
Will Harris
On 2014/12/22 23:07:11, Will Harris wrote: > On 2014/12/22 20:54:56, Will Harris wrote: > > ...
5 years, 11 months ago (2014-12-30 11:04:45 UTC) #5
Mark P
actions.xml lgtm
5 years, 11 months ago (2015-01-02 18:41:15 UTC) #6
Will Harris
ping for chrome/browser/ui/views
5 years, 11 months ago (2015-01-02 22:29:13 UTC) #8
msw
https://codereview.chromium.org/819163002/diff/1/chrome/browser/ui/views/hung_renderer_view.cc File chrome/browser/ui/views/hung_renderer_view.cc (right): https://codereview.chromium.org/819163002/diff/1/chrome/browser/ui/views/hung_renderer_view.cc#newcode288 chrome/browser/ui/views/hung_renderer_view.cc:288: content::RecordAction(UserMetricsAction("HungRendererDialogView.Shown")); Should this be outside of the active Widget ...
5 years, 11 months ago (2015-01-02 22:58:35 UTC) #9
Will Harris
5 years, 9 months ago (2015-02-28 21:14:09 UTC) #10
It seems the issue in the corresponding bug was fixed so no need to add these. 
Closing.

Powered by Google App Engine
This is Rietveld 408576698