Add UMA actions for elements on the Hung Renderer Dialog

chrome/browser/ui/views/hung_renderer_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/hung_renderer_view.h"
 
 #include "base/i18n/rtl.h"
 #include "base/memory/scoped_vector.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/favicon/favicon_tab_helper.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/chrome_web_modal_dialog_manager_delegate.h"
 #include "chrome/browser/ui/tab_contents/core_tab_helper.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_iterator.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/logging_chrome.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/constrained_window/constrained_window_views.h"
 #include "components/web_modal/web_contents_modal_dialog_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
+#include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/result_codes.h"
 #include "grit/theme_resources.h"
 #include "ui/aura/window.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/canvas.h"
 #include "ui/views/controls/button/label_button.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/controls/label.h"
 #include "ui/views/layout/grid_layout.h"
 #include "ui/views/layout/layout_constants.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/window/client_view.h"
 
 #if defined(OS_WIN)
 #include "chrome/browser/hang_monitor/hang_crash_dump_win.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/shell_integration.h"
 #include "ui/base/win/shell.h"
 #include "ui/views/win/hwnd_util.h"
 #endif
 
+using base::UserMetricsAction;
 using content::WebContents;
 
 HungRendererDialogView* HungRendererDialogView::g_instance_ = NULL;
 
 ///////////////////////////////////////////////////////////////////////////////
 // HungPagesTableModel, public:
 
 HungPagesTableModel::HungPagesTableModel(Delegate* delegate)
     : observer_(NULL),
       delegate_(delegate) {
@@ skipping 220 matching lines @@
 #endif
 
     // We only do this if the window isn't active (i.e. hasn't been shown yet,
     // or is currently shown but deactivated for another WebContents). This is
     // because this window is a singleton, and it's possible another active
     // renderer may hang while this one is showing, and we don't want to reset
     // the list of hung pages for a potentially unrelated renderer while this
     // one is showing.
     hung_pages_table_model_->InitForWebContents(contents);
     GetWidget()->Show();
+    content::RecordAction(UserMetricsAction("HungRendererDialogView.Shown"));

[msw, 2015/01/02 22:58:35]

Should this be outside of the active Widget check? (Do you want to record this
metric if the dialog is triggered while it's already open, perhaps if a second
tab is hung?)

Further, should this be before the early return at the top of the function? (Do
you want to record this metric if the dialog is stifled because the browser
window isn't active when the hang is detected?)

At the most extreme, should this be recorded even earlier in
HungRendererDialogView::Show(), if there is no root window or if
logging::DialogsAreSuppressed()?

I'm not so sure that recording the number of times the dialog is shown (at least
like this) will correlate strongly with the number of detected page
hangs/crashes reported through other mechanisms...

   }
 }
 
 void HungRendererDialogView::EndForWebContents(WebContents* contents) {
   DCHECK(contents);
   if (hung_pages_table_model_->RowCount() == 0 ||
       hung_pages_table_model_->GetRenderProcessHost() ==
       contents->GetRenderProcessHost()) {
     GetWidget()->Close();
+    content::RecordAction(UserMetricsAction("HungRendererDialogView.Closed"));

[msw, 2015/01/02 22:58:35]

Should this also be recorded in HungRendererDialogView::TabDestroyed()?
Perhaps override DialogDelegate::OnClosed() to record this instead?

     // Close is async, make sure we drop our references to the tab immediately
     // (it may be going away).
     hung_pages_table_model_->InitForWebContents(NULL);
   }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // HungRendererDialogView, views::DialogDelegate implementation:
 
 base::string16 HungRendererDialogView::GetWindowTitle() const {
@@ skipping 26 matching lines @@
   DCHECK(!kill_button_);
   kill_button_ = new views::LabelButton(this,
       l10n_util::GetStringUTF16(IDS_BROWSER_HANGMONITOR_RENDERER_END));
   kill_button_->SetStyle(views::Button::STYLE_BUTTON);
   return kill_button_;
 }
 
 bool HungRendererDialogView::Accept(bool window_closing) {
   // Don't do anything if we're being called only because the dialog is being
   // destroyed and we don't supply a Cancel function...
-  if (window_closing)
+  if (window_closing) {
+    content::RecordAction(
+        UserMetricsAction("HungRendererDialogView.CloseButton"));
     return true;
+  }
 
   // Start waiting again for responsiveness.
-  if (hung_pages_table_model_->GetRenderViewHost())
+  if (hung_pages_table_model_->GetRenderViewHost()) {
+    content::RecordAction(
+        UserMetricsAction("HungRendererDialogView.WaitButton"));
     hung_pages_table_model_->GetRenderViewHost()->RestartHangMonitorTimeout();
+  }
   return true;
 }
 
 
 bool HungRendererDialogView::UseNewStyleForThisDialog() const {
 #if defined(OS_WIN)
   // Use the old dialog style without Aero glass, otherwise the dialog will be
   // visually constrained to browser window bounds. See http://crbug.com/323278
   return ui::win::IsAeroGlassEnabled();
 #else
   return views::DialogDelegateView::UseNewStyleForThisDialog();
 #endif
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // HungRendererDialogView, views::ButtonListener implementation:
 
 void HungRendererDialogView::ButtonPressed(
     views::Button* sender, const ui::Event& event) {
   if (sender == kill_button_ &&
       hung_pages_table_model_->GetRenderProcessHost()) {
+    content::RecordAction(
+        UserMetricsAction("HungRendererDialogView.KillButton"));
     KillRendererProcess(hung_pages_table_model_->GetRenderProcessHost());
   }
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // HungRendererDialogView, HungPagesTableModel::Delegate overrides:
 
 void HungRendererDialogView::TabDestroyed() {
   GetWidget()->Close();
 }
@@ skipping 61 matching lines @@
 
 // static
 void HungRendererDialogView::InitClass() {
   static bool initialized = false;
   if (!initialized) {
     ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
     frozen_icon_ = rb.GetImageSkiaNamed(IDR_FROZEN_TAB_ICON);
     initialized = true;
   }
 }